Skip to content

Commit dd21fa0

Browse files
committed
test: Skip q11 outside of safe
1 parent da31e03 commit dd21fa0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tpch/queries/q11.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
from narwhals.typing import FrameT
99

1010

11-
# NOTE: Can fail when `scale_factor=0.11`
12-
# Seems to be an upstream issue for hardcoded `var2 = 0.0001`
13-
# https://github.com/duckdb/duckdb/issues/17965
1411
def query(nation_ds: FrameT, partsupp_ds: FrameT, supplier_ds: FrameT) -> FrameT:
1512
var1 = "GERMANY"
1613
var2 = 0.0001

tpch/tests/conftest.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,10 @@ def iter_queries() -> Iterator[Query]:
147147
SUPPLIER_PATH,
148148
),
149149
q("q10", CUSTOMER_PATH, NATION_PATH, LINEITEM_PATH, ORDERS_PATH),
150-
q("q11", NATION_PATH, PARTSUPP_PATH, SUPPLIER_PATH),
150+
q("q11", NATION_PATH, PARTSUPP_PATH, SUPPLIER_PATH).with_skip(
151+
lambda _, scale_factor: scale_factor not in safe,
152+
reason="https://github.com/duckdb/duckdb/issues/17965",
153+
),
151154
q("q12", LINEITEM_PATH, ORDERS_PATH),
152155
q("q13", CUSTOMER_PATH, ORDERS_PATH),
153156
q("q14", LINEITEM_PATH, PART_PATH),

0 commit comments

Comments
 (0)