Skip to content

Commit e5a1237

Browse files
authored
Merge branch 'main' into oh-nodes
2 parents 4a05028 + 46eb2a8 commit e5a1237

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ build-backend = "hatchling.build"
55

66
[project]
77
name = "narwhals"
8-
version = "1.40.0"
8+
version = "1.41.0"
99
dependencies = []
1010
requires-python = ">=3.8"
1111
authors = [

tests/frame/getitem_test.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,12 @@ def test_slice_with_series(
314314
assert_equal_data(result, expected)
315315

316316

317-
def test_horizontal_slice_with_series(constructor_eager: ConstructorEager) -> None:
317+
def test_horizontal_slice_with_series(
318+
constructor_eager: ConstructorEager, request: pytest.FixtureRequest
319+
) -> None:
320+
if "cudf" in str(constructor_eager):
321+
# https://github.com/rapidsai/cudf/issues/18556
322+
request.applymarker(pytest.mark.xfail)
318323
data = {"a": [1, 2], "c": [0, 2], "d": ["c", "a"]}
319324
nw_df = nw.from_native(constructor_eager(data), eager_only=True)
320325
result = nw_df[nw_df["d"]]
@@ -328,9 +333,6 @@ def test_horizontal_slice_with_series_2(
328333
if "pandas_pyarrow" in str(constructor_eager):
329334
# https://github.com/pandas-dev/pandas/issues/61311
330335
request.applymarker(pytest.mark.xfail)
331-
if "cudf" in str(constructor_eager):
332-
# https://github.com/rapidsai/cudf/issues/18556
333-
request.applymarker(pytest.mark.xfail)
334336
data = {"a": [1, 2], "c": [0, 2], "d": ["c", "a"]}
335337
nw_df = nw.from_native(constructor_eager(data), eager_only=True)
336338
result = nw_df[:, nw_df["c"]]

0 commit comments

Comments
 (0)