Skip to content

Commit ebc1a8f

Browse files
committed
added some thoughts, currently going in circles
1 parent 76232df commit ebc1a8f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

narwhals/translate.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -548,6 +548,10 @@ def _from_native_impl( # noqa: C901, PLR0911, PLR0912, PLR0915
548548
for plugin in discovered_plugins:
549549

550550
obj = plugin.load()
551+
552+
# instead of the below, have something more generic like the
553+
# _load_backend in pandas
554+
# https://github.com/pandas-dev/pandas/blob/d95bf9a04f10590fff41e75de94c321a8743af72/pandas/plotting/_core.py#L1872
551555
frame = obj.dataframe.DaftLazyFrame
552556

553557
#from obj.dataframe import DaftLazyFrame doesn't work directly!

0 commit comments

Comments
 (0)