Skip to content

Commit efcbd68

Browse files
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
1 parent d372db6 commit efcbd68

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

narwhals/_sql/expr.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
combine_alias_output_names,
1616
combine_evaluate_output_names,
1717
)
18-
from narwhals._sql.typing import SQLLazyFrameT, NativeSQLExprT
18+
from narwhals._sql.typing import NativeSQLExprT, SQLLazyFrameT
1919
from narwhals._utils import Implementation, Version, not_implemented
2020

2121
if TYPE_CHECKING:
@@ -496,7 +496,8 @@ def round(self, decimals: int) -> Self:
496496
return self._with_elementwise(
497497
lambda expr: self._function("round", expr, self._lit(decimals))
498498
)
499-
# WIP: trying new NativeSQLExprT
499+
500+
# WIP: trying new NativeSQLExprT
500501
def sqrt(self) -> Self:
501502
def _sqrt(expr: NativeSQLExprT) -> NativeSQLExprT:
502503
return self._when(

narwhals/_sql/typing.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
from narwhals._compliant.expr import NativeExpr
66

77
if TYPE_CHECKING:
8+
from typing_extensions import Self
9+
810
from narwhals._sql.dataframe import SQLLazyFrame
911
from narwhals._sql.expr import SQLExpr
10-
from narwhals.dtypes import Boolean
11-
from typing_extensions import Self
1212

1313
# TODO: @mp, understand why these are here & if we need one for NativeSQLExprT
1414
SQLExprAny = SQLExpr[Any, Any]
@@ -18,10 +18,11 @@
1818
SQLExprT_contra = TypeVar("SQLExprT_contra", bound="SQLExprAny", contravariant=True)
1919
SQLLazyFrameT = TypeVar("SQLLazyFrameT", bound="SQLLazyFrameAny")
2020
# TODO: @mp, should this be contravariant as to do with function arguments? think through!
21-
NativeSQLExprT = TypeVar("NativeSQLExprT", bound="NativeSQLExpr")
21+
NativeSQLExprT = TypeVar("NativeSQLExprT", bound="NativeSQLExpr")
22+
2223

2324
class NativeSQLExpr(NativeExpr):
24-
# both Self because we're comparing an expression with an expression?
25+
# both Self because we're comparing an expression with an expression?
2526
def __gt__(self, value: Self) -> Self: ...
2627

2728
def __lt__(self, value: Self) -> Self: ...

0 commit comments

Comments
 (0)