refactor: migrate to ArrowExpr._reuse_series_namespace_implementation

Only 3 errors left - all seem to be `Expr.is_in`

Author: dangotbanned

narwhals/_arrow/expr_cat.py

@@ -2,8 +2,6 @@
 
 from typing import TYPE_CHECKING
 
-from narwhals._expression_parsing import reuse_series_namespace_implementation
-
 if TYPE_CHECKING:
     from typing_extensions import Self
 
@@ -15,6 +13,6 @@ def __init__(self: Self, expr: ArrowExpr) -> None:
         self._compliant_expr = expr
 
     def get_categories(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "cat", "get_categories"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "cat", "get_categories"
         )

narwhals/_arrow/expr_dt.py

@@ -2,8 +2,6 @@
 
 from typing import TYPE_CHECKING
 
-from narwhals._expression_parsing import reuse_series_namespace_implementation
-
 if TYPE_CHECKING:
     from typing_extensions import Self
 
@@ -16,92 +14,92 @@ def __init__(self: Self, expr: ArrowExpr) -> None:
         self._compliant_expr = expr
 
     def to_string(self: Self, format: str) -> ArrowExpr:  # noqa: A002
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "to_string", format=format
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "to_string", format=format
         )
 
     def replace_time_zone(self: Self, time_zone: str | None) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "replace_time_zone", time_zone=time_zone
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "replace_time_zone", time_zone=time_zone
         )
 
     def convert_time_zone(self: Self, time_zone: str) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "convert_time_zone", time_zone=time_zone
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "convert_time_zone", time_zone=time_zone
         )
 
     def timestamp(self: Self, time_unit: TimeUnit) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "timestamp", time_unit=time_unit
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "timestamp", time_unit=time_unit
         )
 
     def date(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(self._compliant_expr, "dt", "date")
+        return self._compliant_expr._reuse_series_namespace_implementation("dt", "date")
 
     def year(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(self._compliant_expr, "dt", "year")
+        return self._compliant_expr._reuse_series_namespace_implementation("dt", "year")
 
     def month(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(self._compliant_expr, "dt", "month")
+        return self._compliant_expr._reuse_series_namespace_implementation("dt", "month")
 
     def day(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(self._compliant_expr, "dt", "day")
+        return self._compliant_expr._reuse_series_namespace_implementation("dt", "day")
 
     def hour(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(self._compliant_expr, "dt", "hour")
+        return self._compliant_expr._reuse_series_namespace_implementation("dt", "hour")
 
     def minute(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(self._compliant_expr, "dt", "minute")
+        return self._compliant_expr._reuse_series_namespace_implementation("dt", "minute")
 
     def second(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(self._compliant_expr, "dt", "second")
+        return self._compliant_expr._reuse_series_namespace_implementation("dt", "second")
 
     def millisecond(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "millisecond"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "millisecond"
         )
 
     def microsecond(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "microsecond"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "microsecond"
         )
 
     def nanosecond(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "nanosecond"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "nanosecond"
         )
 
     def ordinal_day(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "ordinal_day"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "ordinal_day"
         )
 
     def weekday(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "weekday"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "weekday"
         )
 
     def total_minutes(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "total_minutes"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "total_minutes"
         )
 
     def total_seconds(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "total_seconds"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "total_seconds"
         )
 
     def total_milliseconds(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "total_milliseconds"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "total_milliseconds"
         )
 
     def total_microseconds(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "total_microseconds"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "total_microseconds"
         )
 
     def total_nanoseconds(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "dt", "total_nanoseconds"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "dt", "total_nanoseconds"
         )

narwhals/_arrow/expr_list.py

@@ -2,8 +2,6 @@
 
 from typing import TYPE_CHECKING
 
-from narwhals._expression_parsing import reuse_series_namespace_implementation
-
 if TYPE_CHECKING:
     from typing_extensions import Self
 
@@ -15,4 +13,4 @@ def __init__(self: Self, expr: ArrowExpr) -> None:
         self._expr = expr
 
     def len(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(self._expr, "list", "len")
+        return self._expr._reuse_series_namespace_implementation("list", "len")

narwhals/_arrow/expr_str.py

@@ -2,8 +2,6 @@
 
 from typing import TYPE_CHECKING
 
-from narwhals._expression_parsing import reuse_series_namespace_implementation
-
 if TYPE_CHECKING:
     from typing_extensions import Self
 
@@ -15,15 +13,14 @@ def __init__(self: Self, expr: ArrowExpr) -> None:
         self._compliant_expr = expr
 
     def len_chars(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "len_chars"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "len_chars"
         )
 
     def replace(
         self: Self, pattern: str, value: str, *, literal: bool, n: int
     ) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr,
+        return self._compliant_expr._reuse_series_namespace_implementation(
             "str",
             "replace",
             pattern=pattern,
@@ -33,8 +30,7 @@ def replace(
         )
 
     def replace_all(self: Self, pattern: str, value: str, *, literal: bool) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr,
+        return self._compliant_expr._reuse_series_namespace_implementation(
             "str",
             "replace_all",
             pattern=pattern,
@@ -43,46 +39,46 @@ def replace_all(self: Self, pattern: str, value: str, *, literal: bool) -> Arrow
         )
 
     def strip_chars(self: Self, characters: str | None) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "strip_chars", characters=characters
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "strip_chars", characters=characters
         )
 
     def starts_with(self: Self, prefix: str) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "starts_with", prefix=prefix
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "starts_with", prefix=prefix
         )
 
     def ends_with(self: Self, suffix: str) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "ends_with", suffix=suffix
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "ends_with", suffix=suffix
         )
 
     def contains(self: Self, pattern: str, *, literal: bool) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "contains", pattern=pattern, literal=literal
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "contains", pattern=pattern, literal=literal
         )
 
     def slice(self: Self, offset: int, length: int | None) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "slice", offset=offset, length=length
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "slice", offset=offset, length=length
         )
 
     def split(self: Self, by: str) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "split", by=by
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "split", by=by
         )
 
     def to_datetime(self: Self, format: str | None) -> ArrowExpr:  # noqa: A002
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "to_datetime", format=format
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "to_datetime", format=format
         )
 
     def to_uppercase(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "to_uppercase"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "to_uppercase"
         )
 
     def to_lowercase(self: Self) -> ArrowExpr:
-        return reuse_series_namespace_implementation(
-            self._compliant_expr, "str", "to_lowercase"
+        return self._compliant_expr._reuse_series_namespace_implementation(
+            "str", "to_lowercase"
         )