deps: Bump polars min version to 0.20.4 (#2735)

* deps: Bump polars min version to 0.20.4

* generate_random_version

Author: FBruzzesi

.github/workflows/extremes.yml

@@ -25,7 +25,7 @@ jobs:
           cache-suffix: ${{ matrix.python-version }}
           cache-dependency-glob: "pyproject.toml"
       - name: install-minimum-versions
-        run: uv pip install pipdeptree tox virtualenv setuptools pandas==1.1.3 polars==0.20.3 numpy==1.19.3 pyarrow==11.0.0 "pyarrow-stubs<17" scipy==1.6.0 scikit-learn==1.1.0 duckdb==1.0 tzdata --system
+        run: uv pip install pipdeptree tox virtualenv setuptools pandas==1.1.3 polars==0.20.4 numpy==1.19.3 pyarrow==11.0.0 "pyarrow-stubs<17" scipy==1.6.0 scikit-learn==1.1.0 duckdb==1.0 tzdata --system
       - name: install-reqs
         run: |
           uv pip install -e . --group tests --system
@@ -35,7 +35,7 @@ jobs:
         run: |
           DEPS=$(uv pip freeze)
           echo "$DEPS" | grep 'pandas==1.1.3'
-          echo "$DEPS" | grep 'polars==0.20.3'
+          echo "$DEPS" | grep 'polars==0.20.4'
           echo "$DEPS" | grep 'numpy==1.19.3'
           echo "$DEPS" | grep 'pyarrow==11.0.0'
           echo "$DEPS" | grep 'scipy==1.6.0'
@@ -62,7 +62,7 @@ jobs:
           cache-suffix: ${{ matrix.python-version }}
           cache-dependency-glob: "pyproject.toml"
       - name: install-pretty-old-versions
-        run: uv pip install pipdeptree tox virtualenv setuptools pandas==1.1.5 polars==0.20.3 numpy==1.19.3 pyarrow==11.0.0 "pyarrow-stubs<17" scipy==1.6.0 scikit-learn==1.1.0 duckdb==1.0 tzdata --system
+        run: uv pip install pipdeptree tox virtualenv setuptools pandas==1.1.5 polars==0.20.4 numpy==1.19.3 pyarrow==11.0.0 "pyarrow-stubs<17" scipy==1.6.0 scikit-learn==1.1.0 duckdb==1.0 tzdata --system
       - name: install-reqs
         run: uv pip install -e . --group tests --system
       - name: show-deps
@@ -73,7 +73,7 @@ jobs:
         run : |
           DEPS=$(uv pip freeze)
           echo "$DEPS" | grep 'pandas==1.1.5'
-          echo "$DEPS" | grep 'polars==0.20.3'
+          echo "$DEPS" | grep 'polars==0.20.4'
           echo "$DEPS" | grep 'numpy==1.19.3'
           echo "$DEPS" | grep 'pyarrow==11.0.0'
           echo "$DEPS" | grep 'scipy==1.6.0'

narwhals/_polars/dataframe.py

@@ -239,11 +239,7 @@ def collect_schema(self) -> dict[str, DType]:
     def with_row_index(self, name: str, order_by: Sequence[str] | None) -> Self:
         frame = self.native
         if order_by is None:
-            result = (
-                frame.with_row_count(name)
-                if self._backend_version < (0, 20, 4)
-                else frame.with_row_index(name)
-            )
+            result = frame.with_row_index(name)
         else:
             end = pl.count() if self._backend_version < (0, 20, 5) else pl.len()
             result = frame.select(

narwhals/_polars/expr.py

@@ -216,11 +216,7 @@ def __invert__(self) -> Self:
         return self._with_native(self.native.__invert__())
 
     def cum_count(self, *, reverse: bool) -> Self:
-        if self._backend_version < (0, 20, 4):
-            result = (~self.native.is_null()).cum_sum(reverse=reverse)
-        else:
-            result = self.native.cum_count(reverse=reverse)
-        return self._with_native(result)
+        return self._with_native(self.native.cum_count(reverse=reverse))
 
     def __narwhals_expr__(self) -> None: ...
     def __narwhals_namespace__(self) -> PolarsNamespace:  # pragma: no cover

narwhals/_polars/series.py

@@ -468,13 +468,7 @@ def value_counts(
         return PolarsDataFrame.from_native(result, context=self)
 
     def cum_count(self, *, reverse: bool) -> Self:
-        if self._backend_version < (0, 20, 4):
-            not_null_series = ~self.native.is_null()
-            result = not_null_series.cum_sum(reverse=reverse)
-        else:
-            result = self.native.cum_count(reverse=reverse)
-
-        return self._with_native(result)
+        return self._with_native(self.native.cum_count(reverse=reverse))
 
     def __contains__(self, other: Any) -> bool:
         try:

narwhals/_polars/utils.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from functools import lru_cache
-from typing import TYPE_CHECKING, Any, TypeVar, cast, overload
+from typing import TYPE_CHECKING, Any, TypeVar, overload
 
 import polars as pl
 
@@ -97,11 +97,7 @@ def native_to_narwhals_dtype(  # noqa: C901, PLR0912
     if isinstance_or_issubclass(dtype, pl.Enum):
         if version is Version.V1:
             return dtypes.Enum()  # type: ignore[call-arg]
-        categories = _DeferredIterable(
-            dtype.categories.to_list
-            if backend_version >= (0, 20, 4)
-            else lambda: cast("list[str]", dtype.categories)
-        )
+        categories = _DeferredIterable(dtype.categories.to_list)
         return dtypes.Enum(categories)
     if dtype == pl.Date:
         return dtypes.Date()

narwhals/_utils.py

@@ -607,7 +607,7 @@ def _backend_version(self) -> tuple[int, ...]:
     Implementation.PYARROW: (11,),
     Implementation.PYSPARK: (3, 5),
     Implementation.PYSPARK_CONNECT: (3, 5),
-    Implementation.POLARS: (0, 20, 3),
+    Implementation.POLARS: (0, 20, 4),
     Implementation.DASK: (2024, 8),
     Implementation.DUCKDB: (1,),
     Implementation.IBIS: (6,),

noxfile.py

@@ -46,7 +46,7 @@ def pytest_coverage(session: Session) -> None:
 def min_and_old_versions(session: Session, pandas_version: str) -> None:
     session.install(
         f"pandas=={pandas_version}",
-        "polars==0.20.3",
+        "polars==0.20.4",
         "numpy==1.17.5",
         "pyarrow==11.0.0",
         "scipy==1.5.0",

pyproject.toml

@@ -40,7 +40,7 @@ cudf = ["cudf>=24.10.0"]
 pyarrow = ["pyarrow>=11.0.0"]
 pyspark = ["pyspark>=3.5.0"]
 pyspark-connect = ["pyspark[connect]>=3.5.0"]
-polars = ["polars>=0.20.3"]
+polars = ["polars>=0.20.4"]
 dask = ["dask[dataframe]>=2024.8"]
 duckdb = ["duckdb>=1.0"]
 ibis = ["ibis-framework>=6.0.0", "rich", "packaging", "pyarrow_hotfix"]

tests/expr_and_series/map_batches_test.py

@@ -1,9 +1,7 @@
 from __future__ import annotations
 
-import pytest
-
 import narwhals as nw
-from tests.utils import POLARS_VERSION, ConstructorEager, assert_equal_data
+from tests.utils import ConstructorEager, assert_equal_data
 
 data = {"a": [1, 2, 3], "b": [4, 5, 6], "z": [7.0, 8.0, 9.0]}
 
@@ -14,12 +12,7 @@ def test_map_batches_expr(constructor_eager: ConstructorEager) -> None:
     assert_equal_data(expected, {"a": [2, 3, 4], "b": [5, 6, 7]})
 
 
-def test_map_batches_expr_numpy(
-    request: pytest.FixtureRequest, constructor_eager: ConstructorEager
-) -> None:
-    if "polars" in str(constructor_eager) and POLARS_VERSION <= (0, 20, 3):
-        request.applymarker(pytest.mark.xfail)
-
+def test_map_batches_expr_numpy(constructor_eager: ConstructorEager) -> None:
     df = nw.from_native(constructor_eager(data))
     expected = df.select(
         nw.col("a")
@@ -32,12 +25,7 @@ def test_map_batches_expr_numpy(
     assert_equal_data(expected, {"a": [2], "b": [2], "z": [2]})
 
 
-def test_map_batches_expr_names(
-    request: pytest.FixtureRequest, constructor_eager: ConstructorEager
-) -> None:
-    if "polars" in str(constructor_eager) and POLARS_VERSION <= (0, 20, 3):
-        request.applymarker(pytest.mark.xfail)
-
+def test_map_batches_expr_names(constructor_eager: ConstructorEager) -> None:
     df = nw.from_native(constructor_eager(data))
     expected = nw.from_native(df.select(nw.all().map_batches(lambda x: x.to_numpy())))
     assert_equal_data(expected, {"a": [1, 2, 3], "b": [4, 5, 6], "z": [7.0, 8.0, 9.0]})

utils/generate_random_versions.py

@@ -13,7 +13,6 @@
     ("2.2.2", "1.26.4"),
 ]
 POLARS_VERSION = [
-    "0.20.3",
     "0.20.4",
     "0.20.5",
     "0.20.6",