Updates to `ruff` config

[dangotbanned]

PRs

• chore: enable more Ruff rules (RET505, A005, ISC001, PD003) #2923
• chore: update ruff config #3009

Description

Just collecting some small things that we could change in our config to do less 🙂

Settings

Less # noqa: ...

Mostly for conventions outside of our control like F, Window

• https://docs.astral.sh/ruff/settings/#lint_pep8-naming_extend-ignore-names
• https://docs.astral.sh/ruff/settings/#lint_flake8-builtins_allowed-modules
• https://docs.astral.sh/ruff/settings/#lint_flake8-builtins_ignorelist

Rules

Disable

• https://docs.astral.sh/ruff/rules/snake-case-type-alias/

  • narwhals/narwhals/typing.py

    Lines 348 to 349 in b9bdc34

    	_2DArray: TypeAlias = "_NDArray[tuple[int, int]]" # noqa: PYI042, PYI047
    	_AnyDArray: TypeAlias = "_NDArray[tuple[int, ...]]" # noqa: PYI047

Enable autofix

• https://docs.astral.sh/ruff/rules/raw-string-in-exception/
  • Lets you write the error message in the exception, then fixes it by moving it to msg

Related

• ci: bump ruff==0.12.4 #2845 (comment)
• chore(ruff): add format to builtins-ignorelist #2199

[FBruzzesi]

We can enable the following rules (without any change required):

• "A005", # stdlib-module-shadowing
• "ISC001", # single-line-implicit-string-concatenation
• "PD003", # pandas-use-of-dot-is-null

[dangotbanned]

Thanks @FBruzzesi

I hadn't checked the ignored one's this time, but they all LGTM!

(A005) is also configurable - if we ever need that in the future

• https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/
• https://docs.astral.sh/ruff/rules/single-line-implicit-string-concatenation/
• https://docs.astral.sh/ruff/rules/pandas-use-of-dot-is-null/

[EdAbati]

Hey both :)

One that we also enable is RET505
Since it reduces a bit of indentation, IMO it can really make the code cleaner

Putting a PR together for this (if you agree)

[dangotbanned]

Thanks @EdAbati!

One that we also enable is RET505

I also like that rule, but IIRC it didn't interact well with coverage when I tried it out 😔

If you can get both working at the same time, then I'm all for it 😅