Re-align `altair` internal typing

[dangotbanned]

PRs

• fix(typing): Avoid overlapping DataFrame, LazyFrame #2944
• feat(typing): Add IntoBackend alias #2971

Related

• feat(typing): Add IntoBackend alias #2971 (comment)
• fix(typing): Avoid overlapping DataFrame, LazyFrame #2944 (comment)

Description

After both of these PRs merge, our ci will start warning about altair's typing.

FYI I (@dangotbanned) wrote that code, it hasn't been released yet and the typing was based directly on what is being narrowed/fixed in these new PRs

[FBruzzesi]

Thanks for the tracking! I will try to prioritize the review of #2944 later today, so that we can then fix the issue in altair

[FBruzzesi]

@dangotbanned just to make sure, we need/want #3016 before addressing the issue in altair? I noticed you marked #3016 ready for review, I will try to take a look tonight

[dangotbanned]

Thanks for the ping @FBruzzesi

I hadn't thought of this before, but yeah it would probably make closing this issue easier actually 😄

[MarcoGorelli]

hi - looks like the linked issues are closed, is there anything we need to do our side to facilitate this?

[MarcoGorelli]

@dangotbanned could you update us on this one please?

i've noticed dangotbanned/altair@8083310, but i'd strongly advice against bumping the minimum narwhals version in altair if this is just for the purposes of internal type checking

[MarcoGorelli]

From Dan's message in Discord: https://discord.com/channels/1235257048170762310/1426572459423039571/1426572520173080576

if this is just for the purposes of internal type checking

dangotbanned/altair/fix-narwhals-typing has the fixes needed to get the typing working again.

I used internal typing in the title, but the description is more accurate:

FYI I (@dangotbanned) wrote that code, it hasn't been released yet and the typing was based directly on what is being narrowed/fixed in these new PRs

The new API that the typing is for will be public.
In it's current state it is broken in various ways depending on the narwhals version, due to:
from_native stuff that leads into #3125.
I was explicitly handling TypeVars for each ofDataFrame/LazyFrame
I'm assuming no other downstream project did this, or they would've had the same problems 😅
I was accidentally using LazyFrame recursively
Implementation #2971, #3016
I was incorrectly passing lazy-only to from_dict

The last altair release v5.5.0 was on 2024-11-24 which has a minimum "narwhals>=1.14.2".

I think not bumping the narwhals version after all that time may be more of an issue.
IIRC, we (altair) weren't testing against that minimum and we (narwhals) are testing against main 😳