chore: Add _typing_compat module
#2578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 tasks
|
To expand on the link to (#2572) some more ... Ideally, it would be good to (statically) know the type of every node in an expression. There's a big benefit to knowing as much information of the graph as possible - to avoid needing |
MarcoGorelli
approved these changes
May 21, 2025
dangotbanned
added a commit
that referenced
this pull request
May 22, 2025
- Needed to add the `ruff` config in the end (#2578) - Prevented forward refs in `TypeVar` from showing as unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
importlib.util.find_spec#2391 (comment))ExprIR #2572)Checklist
If you have comments or can explain your changes, please do so below
Module doc preview
I was originally expecting we'd need to add some config for
ruffandmypy.Haven't had any issues without it, so I'm not sure we need it?