refactor(expr-ir): Improve function dispatch #3215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this api still needs a LOT of work
much closer now, need to move to metaclass soon
No need for re-computing when the name is stored on the class
73 tasks
it ain't much, but its a start
…spatcher.__call__` Pretty nice property to have
dangotbanned
commented
Oct 18, 2025
Comment on lines
-43
to
-45
| __expr_ir_dispatch__: ClassVar[ | ||
| staticmethod[[Incomplete, FunctionExpr[Self], Incomplete, str], Incomplete] | ||
| ] |
There was a problem hiding this comment.
Truly wild that I wrote ^^^ 😂
The new version looks a bit more understandable from the outside - but it now can correctly scope all the things which were Incomplete.
__expr_ir_dispatch__: ClassVar[Dispatcher[FunctionExpr[Self]]]
dangotbanned
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
ExprIR #2572Checklist
Description
Fixing some gaps in error handling, typing and generally dressing up some functional stuff that got a bit out-of-hand for my liking 😅