CMR-10388: Checking return type from access control

Author: eereiter

subscription/src/access_control.py

@@ -66,7 +66,9 @@ def get_url_from_parameter_store(self):
             port = env_vars.get_var(name=port_param_name)
             host = env_vars.get_var(name=host_param_name)
             context = env_vars.get_var(name=context_param_name)
-            self.url = f"{protocol}://{host}:{port}/{context}"
+
+            # The context already contains the forward / so we don't need it here.
+            self.url = f"{protocol}://{host}:{port}{context}"
             logger.debug(f"Subscription Worker Access-Control URL: {self.url}")
 
     def get_url(self):
@@ -110,10 +112,11 @@ def has_read_permission(self, subscriber_id, collection_concept_id):
 
         try:
             # Call the get_permissions function
-            permissions = self.get_permissions(subscriber_id, collection_concept_id)
-            logger.info(f"The type of object the permissions is: {type(permissions)}")
-            logger.info(f"If its json then turn it into a Dictionary: {json.load(permissions)}")
+            permissions_str = self.get_permissions(subscriber_id, collection_concept_id)
+            logger.info(f"The type of object the permissions is: {type(permissions_str)}")
+            logger.info(f"If its json then turn it into a Dictionary: {json.loads(permissions_str)}")
 
+            permissions = json.loads(permissions_str)
 
             # Check if the permissions is a dictionary
             if isinstance(permissions, dict):

subscription/test/access_control_test.py

@@ -20,7 +20,7 @@ def test_get_url_from_parameter_store_local(self):
     def test_get_url_from_parameter_store_aws(self, mock_env_vars):
         mock_env_vars_instance = MagicMock()
         mock_env_vars_instance.get_var.side_effect = [
-            "https", "3011", "cmr.sit.earthdata.nasa.gov", "access-control"
+            "https", "3011", "cmr.sit.earthdata.nasa.gov", "/access-control"
         ]
         mock_env_vars.return_value = mock_env_vars_instance