Refactor ImpliedUse

Add unit test for fpp-check

Author: bocchino

compiler/lib/src/main/scala/analysis/Semantics/ImpliedUse.scala

@@ -89,7 +89,6 @@ object ImpliedUse {
     identList: List[Name.Unqualified],
     id: AstNode.Id,
     annotations: List[String] = Nil
-  ) =
-    ImpliedUse(Name.Qualified.fromIdentList(identList), id, annotations)
+  ) = ImpliedUse(Name.Qualified.fromIdentList(identList), id, annotations)
 
 }

compiler/tools/fpp-check/test/port_instance/shadowed_time_get.fpp

@@ -0,0 +1,15 @@
+module M {
+
+  module Fw {
+
+    port Time
+
+  }
+
+  passive component C {
+
+    time get port timeGetOut
+
+  }
+
+}

compiler/tools/fpp-check/test/port_instance/shadowed_time_get.ref.txt

@@ -0,0 +1,10 @@
+fpp-check
+[ local path prefix ]/compiler/tools/fpp-check/test/port_instance/shadowed_time_get.fpp:11.5
+    time get port timeGetOut
+    ^
+error: invalid use of symbol M.Fw.Time: it shadows Fw.Time here
+symbol is defined here:
+[ local path prefix ]/compiler/tools/fpp-check/test/port_instance/shadowed_time_get.fpp:5.5
+    port Time
+    ^
+note: the symbol Fw.Time has an implied use at the point of the error

compiler/tools/fpp-check/test/port_instance/tests.sh

@@ -11,6 +11,7 @@ bad_priority_product_recv
 duplicate_command_recv
 duplicate_general
 ok
+shadowed_time_get
 special_input_kind_command
 special_input_kind_missing_product_recv
 sync_input_priority