deleting instead of null settting to avoid issues on last unsub

jvigliotta · jvigliotta · commit 0f1f6b5b279e · 2026-04-07T15:50:34.000-07:00
diff --git a/src/plugins/condition/ConditionManager.js b/src/plugins/condition/ConditionManager.js
@@ -97,8 +97,8 @@ export default class ConditionManager extends EventEmitter {
     }
 
     this.telemetryCollections[keyString].destroy();
-    this.telemetryCollections[keyString] = null;
-    this.telemetryObjects[keyString] = null;
+    delete this.telemetryCollections[keyString];
+    delete this.telemetryObjects[keyString];
     this.removeConditionTelemetryObjects();
 
     //force re-computation of condition set result as we might be in a state where

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,8 @@ export default class ConditionManager extends EventEmitter {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`this.telemetryCollections[keyString].destroy();`
`100`		`- this.telemetryCollections[keyString] = null;`
`101`		`- this.telemetryObjects[keyString] = null;`
	`100`	`+ delete this.telemetryCollections[keyString];`
	`101`	`+ delete this.telemetryObjects[keyString];`
`102`	`102`	`this.removeConditionTelemetryObjects();`
`103`	`103`
`104`	`104`	`//force re-computation of condition set result as we might be in a state where`