Remove src from npm module?

[ikirk]

I am working on a new application built on OpenMCT. To make updating to newer versions of OpenMCT as they are released, I am consuming it as a package through npm, and to help developers transfer skills from strictly and statically typed languages like C#, I am making the project in Typescript. However, the types that were inferred and output into openmct/dist/types/index.d.ts are not always accurate, so I'm trying to use patch-package to make the necessary changes to index.d.ts in a way that would be easily replicable for other developers. Because of the inclusion of the src directory in the npm package, patch-package fails because of the length of file names (namely "node_modules/openmct/src/plugins/persistence/couch/node_modules/@ibm-cloud/cloudant/node_modules/ibm-cloud-sdk-core/build/docs/ibm-cloud-sdk-core.cloudpakfordataauthenticator.authenticationtype.md").

Because the parts of the module that should actually be used by consuming applications should be from dist, I wouldn't expect that removing src would break applications, and if such applications need access to the src folder they can follow the instructions for building from source, and would come with the added benefit of significantly reducing the time taken to install when running npm install openmct and reducing bloat in the node_modules directory.

What do other users think?

[ikirk]

I've actually changed my mind on this point now that I am wrapping existing Views and see the value of being able to import from the node_modules directory.

[akhenry]

We ship source to support source maps. An optional package without src would be a great idea though.