Skip to content

Commit 707f228

Browse files
authored
Merge pull request #48 from nash1111/issue-47
refactor: use Select
2 parents 5c14736 + 2ce8d4d commit 707f228

File tree

2 files changed

+24
-13
lines changed

2 files changed

+24
-13
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"dependencies": {
1414
"@duckdb/duckdb-wasm": "1.29.1-dev24.0",
1515
"@radix-ui/react-dropdown-menu": "^2.1.5",
16-
"@radix-ui/react-select": "^2.1.5",
16+
"@radix-ui/react-select": "^2.1.6",
1717
"@radix-ui/react-slot": "^1.1.1",
1818
"@radix-ui/react-toast": "^1.2.5",
1919
"@tanstack/react-table": "^8.20.6",

src/Editor.tsx

Lines changed: 23 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
import React, { useEffect, useState } from "react";
22
import * as monaco from "monaco-editor";
3+
import {
4+
Select,
5+
SelectContent,
6+
SelectGroup,
7+
SelectItem,
8+
SelectTrigger,
9+
SelectValue,
10+
} from "@/components/ui/select";
311

412
interface EditorProps {
513
editorRef: React.MutableRefObject<monaco.editor.IStandaloneCodeEditor | null>;
@@ -17,8 +25,8 @@ const Editor: React.FC<EditorProps> = ({ editorRef, runQuery }) => {
1725
}
1826
}, [theme, editorRef]);
1927

20-
const handleThemeChange = (event: React.ChangeEvent<HTMLSelectElement>) => {
21-
setTheme(event.target.value);
28+
const handleThemeChange = (value: string) => {
29+
setTheme(value);
2230
};
2331

2432
useEffect(() => {
@@ -77,16 +85,19 @@ const Editor: React.FC<EditorProps> = ({ editorRef, runQuery }) => {
7785
<button onClick={decreaseFontSize} style={{ marginLeft: "4px" }}>
7886
7987
</button>
80-
<select
81-
onChange={handleThemeChange}
82-
value={theme}
83-
style={{ marginLeft: "8px" }}
84-
>
85-
<option value="vs">vs</option>
86-
<option value="vs-dark">vs-dark</option>
87-
<option value="hc-black">hc-black</option>
88-
<option value="hc-light">hc-light</option>
89-
</select>
88+
<Select onValueChange={handleThemeChange} value={theme}>
89+
<SelectTrigger className="w-[180px] ml-2">
90+
<SelectValue placeholder="Select theme" />
91+
</SelectTrigger>
92+
<SelectContent>
93+
<SelectGroup>
94+
<SelectItem value="vs">VS Light</SelectItem>
95+
<SelectItem value="vs-dark">VS Dark</SelectItem>
96+
<SelectItem value="hc-black">High Contrast Dark</SelectItem>
97+
<SelectItem value="hc-light">High Contrast Light</SelectItem>
98+
</SelectGroup>
99+
</SelectContent>
100+
</Select>
90101
</div>
91102
<div
92103
id="editor"

0 commit comments

Comments
 (0)