Skip to content

Commit e3fdce6

Browse files
committed
cavs: fix LSPGISTS and LSPGCTL access
On cAVS 1.8, 2.0 and 2.5 LSPGISTS and LSPGCTL are located in a different shim register range, they cannot be accessed, using the usual SHIM_BASE offset. Signed-off-by: Guennadi Liakhovetski <[email protected]>
1 parent 96d3cd0 commit e3fdce6

File tree

5 files changed

+3
-14
lines changed

5 files changed

+3
-14
lines changed

soc/xtensa/intel_adsp/cavs_v15/include/soc/shim.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@
204204
#define SHIM_HSPGCTL 0x80
205205
#define SHIM_LSPGCTL 0x84
206206
#define SHIM_SPSREQ 0xa0
207+
#define LSPGCTL (SHIM_BASE + SHIM_LSPGCTL)
207208

208209
#define SHIM_SPSREQ_RVNNP BIT(0)
209210

soc/xtensa/intel_adsp/cavs_v18/include/soc/shim.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,6 @@
236236
#define LSRMCTL 0x71D54
237237
#define LSPGISTS 0x71D58
238238

239-
#define SHIM_LSPGCTL 0x50
240-
#define SHIM_LSPGISTS 0x58
241-
242-
243239
#define SHIM_L2_MECS (SHIM_BASE + 0xd0)
244240

245241
/** \brief LDO Control */

soc/xtensa/intel_adsp/cavs_v20/include/soc/shim.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,10 +230,6 @@
230230
#define LSRMCTL 0x71D54
231231
#define LSPGISTS 0x71D58
232232

233-
#define SHIM_LSPGCTL 0x50
234-
#define SHIM_LSPGISTS 0x58
235-
236-
237233
#define SHIM_L2_MECS (SHIM_BASE + 0xd0)
238234

239235
/** \brief LDO Control */

soc/xtensa/intel_adsp/cavs_v25/include/soc/shim.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,10 +239,6 @@
239239
#define LSRMCTL 0x71D54
240240
#define LSPGISTS 0x71D58
241241

242-
#define SHIM_LSPGCTL 0x50
243-
#define SHIM_LSPGISTS 0x58
244-
245-
246242
#define SHIM_L2_MECS (SHIM_BASE + 0xd0)
247243

248244
/** \brief LDO Control */

soc/xtensa/intel_adsp/common/bootloader/boot_loader.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,8 @@ static int32_t lp_sram_init(void)
301301
/* add some delay before writing power registers */
302302
idelay(delay_count);
303303

304-
lspgctl_value = shim_read(SHIM_LSPGISTS);
305-
shim_write(SHIM_LSPGCTL, lspgctl_value & ~LPSRAM_MASK(0));
304+
lspgctl_value = io_reg_read(LSPGISTS);
305+
io_reg_write(LSPGCTL, lspgctl_value & ~LPSRAM_MASK(0));
306306

307307
/* add some delay before checking the status */
308308
idelay(delay_count);

0 commit comments

Comments
 (0)