test/BE: increase code coverage to 90% (#15)

NhatNguyen1502 · web-flow · commit 5fdf0b9acc71 · 2025-09-30T09:15:34.000+07:00
diff --git a/backend/app/controllers/WorkspaceController.scala b/backend/app/controllers/WorkspaceController.scala
@@ -114,18 +114,6 @@ class WorkspaceController @Inject()(
                 Json.toJson(ApiResponse[Unit]("Workspace updated successfully"))
               )
             }
-      }.recover {
-        case ex: AppException => BadRequest(
-          Json.obj(
-            "message" -> "Duplicate workspace name",
-            "errors" -> Json.arr(
-              Json.obj(
-                "field" -> "name",
-                "message" -> ex.message
-              )
-            )
-          )
-        )
       }
     }
 }
diff --git a/backend/app/services/WorkspaceService.scala b/backend/app/services/WorkspaceService.scala
@@ -95,7 +95,7 @@ class WorkspaceService @Inject() (
             isWorkspaceNameExists <- workspaceRepo.isWorkspaceNameUsedByUser(workspace.name, updatedBy)
             result <- if (isWorkspaceNameExists) {
                 DBIO.failed(AppException(
-                  message = "Workspace name already exists",
+                  message = "Duplicate workspace name",
                   statusCode = Status.CONFLICT
                 ))
             } else {
diff --git a/backend/conf/application.test.conf b/backend/conf/application.test.conf
@@ -11,6 +11,7 @@ play.evolutions.db.default.enabled = true
 play.evolutions.db.default.autoApply = true
 play.evolutions.db.default.autoApplyDowns = true
 
+play.http.errorHandler = "exception.CustomErrorHandler"
 
 admin {
     email = "test@gmail.com"
diff --git a/backend/test/controllers/ColumnControllerSpec.scala b/backend/test/controllers/ColumnControllerSpec.scala
@@ -1,10 +1,7 @@
 package controllers
 
-import dto.request.column.{
-  CreateColumnRequest,
-  UpdateColumnPositionRequest,
-  UpdateColumnRequest
-}
+import dto.request.column.{CreateColumnRequest, UpdateColumnPositionRequest, UpdateColumnRequest}
+import dto.response.column.ColumnSummariesResponse
 import exception.AppException
 import org.scalatest.BeforeAndAfterAll
 import org.scalatest.concurrent.ScalaFutures
@@ -206,6 +203,18 @@ class ColumnControllerSpec
         .as[String] mustBe "Column archived successfully"
     }
 
+    "should get archived columns successfully" in {
+      val request = FakeRequest(GET, "/api/projects/1/columns/archived").withCookies(
+        Cookie(cookieName, fakeToken)
+      )
+      val result = route(app, request).get
+
+      status(result) mustBe OK
+      (contentAsJson(result) \ "message").as[String] mustBe "Archived columns retrieved"
+      val data = (contentAsJson(result) \ "data").as[Seq[ColumnSummariesResponse]]
+      data.length must be > 0
+    }
+
     "restore column successfully" in {
       val request = FakeRequest(PATCH, "/api/columns/1/restore")
         .withCookies(Cookie(cookieName, fakeToken))
diff --git a/backend/test/controllers/ProjectControllerSpec.scala b/backend/test/controllers/ProjectControllerSpec.scala
@@ -25,6 +25,7 @@ class ProjectControllerSpec
     new GuiceApplicationBuilder()
       .configure(
         "config.resource" -> "application.test.conf",
+        "play.http.errorHandler" -> "exception.CustomErrorHandler",
         "slick.dbs.default.db.url" -> s"jdbc:h2:mem:projecttest;DB_CLOSE_DELAY=-1;DB_CLOSE_ON_EXIT=FALSE;MODE=PostgreSQL;DATABASE_TO_UPPER=false"
       )
       .build()
@@ -75,6 +76,19 @@ class ProjectControllerSpec
       (contentAsJson(result) \ "message").as[String] must include("Project created successfully")
     }
 
+    "fail when project name already exists" in {
+      val body = Json.toJson(CreateProjectRequest("New Project"))
+      val request = FakeRequest(POST, "/api/workspaces/1/projects")
+        .withCookies(Cookie(cookieName, fakeToken))
+        .withBody(body)
+
+      val ex = intercept[AppException] {
+        await(route(app, request).get)
+      }
+      ex.statusCode mustBe CONFLICT
+      ex.message must include("Project name 'New Project' already exists")
+    }
+
     "fail when workspace does not exist" in {
       val nonExistentWorkspaceId = 9999
       val body = Json.toJson(CreateProjectRequest("Orphan Project"))
@@ -99,6 +113,40 @@ class ProjectControllerSpec
       (contentAsJson(result) \ "message").as[String] mustBe "Projects retrieved"
     }
 
+    "fail when get project in workspace not exist" in {
+      val request = FakeRequest(GET, "/api/workspaces/0/projects")
+        .withCookies(Cookie(cookieName, fakeToken))
+
+        val ex = intercept[AppException] {
+        await(route(app, request).get)
+        }
+        ex.statusCode mustBe NOT_FOUND
+        ex.message must include("Workspace not found")
+    }
+
+    "retrieve projects by id" in {
+      val request = FakeRequest(GET, "/api/projects/1")
+        .withCookies(Cookie(cookieName, fakeToken))
+      val result = route(app, request).get
+
+      status(result) mustBe OK
+      (contentAsJson(result) \ "message").as[String] mustBe "Project retrieved"
+      val projectId = (contentAsJson(result) \ "data" \ "id").as[Int]
+      projectId mustBe 1
+    }
+
+    "fail when get project with unexisting id" in {
+      val request = FakeRequest(GET, "/api/projects/0")
+        .withCookies(Cookie(cookieName, fakeToken))
+
+      val ex = intercept[AppException] {
+        await(route(app, request).get)
+      }
+      ex.statusCode mustBe NOT_FOUND
+      ex.message must include("Project not found")
+
+    }
+
     "complete project successfully" in {
       val projectId = 1
       val request = FakeRequest(PATCH, s"/api/projects/$projectId/complete")
@@ -121,20 +169,6 @@ class ProjectControllerSpec
       ex.message must include("Project not found or you are not the owner")
     }
 
-//    "delete project successfully" in {
-//      val projectId = 1
-//      val completeRequest = FakeRequest(PATCH, s"/api/projects/$projectId/complete")
-//        .withCookies(Cookie(cookieName, fakeToken))
-//      status(route(app, completeRequest).get) mustBe OK
-//
-//      val request = FakeRequest(PATCH, s"/api/projects/$projectId/delete")
-//        .withCookies(Cookie(cookieName, fakeToken))
-//      val result = route(app, request).get
-//
-//      status(result) mustBe OK
-//      (contentAsJson(result) \ "message").as[String] mustBe "Project deleted successfully"
-//    }
-
     "reopen project successfully" in {
       val projectId = 1
       val request = FakeRequest(PATCH, s"/api/projects/$projectId/reopen")
@@ -174,5 +208,19 @@ class ProjectControllerSpec
       ex.statusCode mustBe NOT_FOUND
       ex.message must include("Project not found")
     }
+
+    "delete project successfully" in {
+      val projectId = 1
+      val completeRequest = FakeRequest(PATCH, s"/api/projects/$projectId/complete")
+        .withCookies(Cookie(cookieName, fakeToken))
+      status(route(app, completeRequest).get) mustBe OK
+
+      val request = FakeRequest(PATCH, s"/api/projects/$projectId/delete")
+        .withCookies(Cookie(cookieName, fakeToken))
+      val result = route(app, request).get
+
+      status(result) mustBe OK
+      (contentAsJson(result) \ "message").as[String] mustBe "Project deleted successfully"
+    }
   }
 }
diff --git a/backend/test/controllers/TaskControllerSpec.scala b/backend/test/controllers/TaskControllerSpec.scala
@@ -1,8 +1,10 @@
 package controllers
 
-import dto.request.column.CreateColumnRequest
-import dto.request.task.{AssignMemberRequest, CreateTaskRequest, UpdateTaskRequest}
-import dto.request.task.{CreateTaskRequest, UpdateTaskRequest}
+import dto.request.task.{
+  AssignMemberRequest,
+  CreateTaskRequest,
+  UpdateTaskRequest
+}
 import dto.response.task.{TaskSearchResponse, TaskSummaryResponse}
 import exception.AppException
 import org.scalatest.BeforeAndAfterAll
@@ -18,7 +20,7 @@ import play.api.{Application, Configuration}
 import services._
 
 class TaskControllerSpec
-  extends PlaySpec
+    extends PlaySpec
     with GuiceOneAppPerSuite
     with Injecting
     with ScalaFutures
@@ -86,6 +88,21 @@ class TaskControllerSpec
       )
     }
 
+    "fail when creating task with unexisting column id" in {
+      val body = Json.toJson(CreateTaskRequest("Task 1", 1))
+      val request = FakeRequest(POST, "/api/columns/0/tasks")
+        .withCookies(Cookie(cookieName, fakeToken))
+        .withBody(body)
+
+      val ex = intercept[AppException] {
+        await(route(app, request).get)
+      }
+      ex.statusCode mustBe NOT_FOUND
+      ex.message must include(
+        "Column with ID 0 does not exist or is not active"
+      )
+    }
+
     "assign member into a task successfully" in {
       val body = Json.toJson(AssignMemberRequest(1))
       val request = FakeRequest(POST, "/api/projects/1/tasks/1/members")
@@ -100,6 +117,20 @@ class TaskControllerSpec
       )
     }
 
+    "fail when assign member with unexist task id" in {
+      val body = Json.toJson(AssignMemberRequest(1))
+      val request = FakeRequest(POST, "/api/projects/1/tasks/0/members")
+        .withCookies(Cookie(cookieName, fakeToken))
+        .withBody(body)
+
+      val ex = intercept[AppException] {
+        await(route(app, request).get)
+      }
+
+      ex.statusCode mustBe NOT_FOUND
+      ex.message must include("Task with ID 0 does not exist")
+    }
+
     "fail when creating task with duplicate position in same column" in {
       val body = Json.toJson(CreateTaskRequest("Task 1", 1))
       val request = FakeRequest(POST, "/api/columns/1/tasks")
@@ -117,7 +148,9 @@ class TaskControllerSpec
 
     "update task successfully" in {
       val body =
-        Json.toJson(UpdateTaskRequest("Updated Task", None, None, None, None, None))
+        Json.toJson(
+          UpdateTaskRequest("Updated Task", None, None, None, None, None)
+        )
       val request = FakeRequest(PATCH, "/api/tasks/1")
         .withCookies(Cookie(cookieName, fakeToken))
         .withBody(body)
@@ -130,10 +163,30 @@ class TaskControllerSpec
         .as[String] mustBe "Task updated successfully"
     }
 
+    "fail when updating task with unexist task id" in {
+      val body =
+        Json.toJson(
+          UpdateTaskRequest("Updated Task", None, None, None, None, None)
+        )
+      val request = FakeRequest(PATCH, "/api/tasks/0")
+        .withCookies(Cookie(cookieName, fakeToken))
+        .withBody(body)
+        .withHeaders(CONTENT_TYPE -> "application/json")
+
+      val ex = intercept[AppException] {
+        await(route(app, request).get)
+      }
+
+      ex.statusCode mustBe NOT_FOUND
+      ex.message must include("Task with ID 0 does not exist")
+    }
+
     "fail to update non-existent task" in {
       val nonExistentTaskId = 9999
       val body =
-        Json.toJson(UpdateTaskRequest("Some Task", None, None, None, None, None))
+        Json.toJson(
+          UpdateTaskRequest("Some Task", None, None, None, None, None)
+        )
       val request = FakeRequest(PATCH, s"/api/tasks/$nonExistentTaskId")
         .withCookies(Cookie(cookieName, fakeToken))
         .withBody(body)
@@ -197,11 +250,7 @@ class TaskControllerSpec
 
       // Create and archive a task in the new column
       val taskId = await(
-        taskService.createNewTask(
-          CreateTaskRequest("Task to Archive", 1),
-          1,
-          1
-        )
+        taskService.createNewTask(CreateTaskRequest("Task to Archive", 1), 1, 1)
       )
       await(taskService.archiveTask(taskId, 1))
 
@@ -216,16 +265,24 @@ class TaskControllerSpec
       tasks.exists(task => task.id == taskId && task.name == "Task to Archive") mustBe true
     }
 
+    "fail when get archived tasks with unexist project id" in {
+      val request = FakeRequest(GET, "/api/projects/0/columns/tasks/archived")
+        .withCookies(Cookie(cookieName, fakeToken))
+      val result = route(app, request).get
+
+      val ex = intercept[AppException] {
+        await(result)
+      }
+      ex.statusCode mustBe NOT_FOUND
+      ex.message must include("Project not found")
+    }
+
     "get active tasks successfully" in {
       val taskService = inject[TaskService]
 
       // Create a new task in the existing column
       val taskId = await(
-        taskService.createNewTask(
-          CreateTaskRequest("Active Task", 1),
-          1,
-          1
-        )
+        taskService.createNewTask(CreateTaskRequest("Active Task", 1), 1, 1)
       )
 
       val request = FakeRequest(GET, "/api/projects/1/columns/tasks/active")
@@ -239,16 +296,24 @@ class TaskControllerSpec
       tasks.exists(task => task.id == taskId && task.name == "Active Task") mustBe true
     }
 
+    "fail get active tasks with unexist project id" in {
+      val request = FakeRequest(GET, "/api/projects/0/columns/tasks/active")
+        .withCookies(Cookie(cookieName, fakeToken))
+      val result = route(app, request).get
+
+      val ex = intercept[AppException] {
+        await(result)
+      }
+      ex.statusCode mustBe NOT_FOUND
+      ex.message must include("Project not found")
+    }
+
     "search tasks successfully" in {
       val taskService = inject[TaskService]
 
       // Create a new task in the existing column
       val taskId = await(
-        taskService.createNewTask(
-          CreateTaskRequest("search Task", 1502),
-          1,
-          1
-        )
+        taskService.createNewTask(CreateTaskRequest("search Task", 1502), 1, 1)
       )
 
       val request = FakeRequest(GET, "/api/tasks?page=1&size=10&keyword=search")
diff --git a/backend/test/controllers/WorkspaceControllerSpec.scala b/backend/test/controllers/WorkspaceControllerSpec.scala

Original file line number	Diff line number	Diff line change
`@@ -114,18 +114,6 @@ class WorkspaceController @Inject()(`
`114`	`114`	`Json.toJson(ApiResponse[Unit]("Workspace updated successfully"))`
`115`	`115`	`)`
`116`	`116`	`}`
`117`		`- }.recover {`
`118`		`- case ex: AppException => BadRequest(`
`119`		`- Json.obj(`
`120`		`- "message" -> "Duplicate workspace name",`
`121`		`- "errors" -> Json.arr(`
`122`		`- Json.obj(`
`123`		`- "field" -> "name",`
`124`		`- "message" -> ex.message`
`125`		`- )`
`126`		`- )`
`127`		`- )`
`128`		`- )`
`129`	`117`	`}`
`130`	`118`	`}`
`131`	`119`	`}`