Fix more leaks

natario1 · natario1 · commit 3a913456e55e · 2019-03-04T20:52:21.000+01:00
diff --git a/library/src/main/kotlin/com/otaliastudios/elements/Adapter.kt b/library/src/main/kotlin/com/otaliastudios/elements/Adapter.kt
@@ -276,6 +276,7 @@ public final class Adapter private constructor(
             it.unbind(this)
         }
         recyclerViews.clear()
+        lifecycle.removeObserver(this)
     }
 
     /**
diff --git a/library/src/main/kotlin/com/otaliastudios/elements/extensions/DataBindingPresenter.kt b/library/src/main/kotlin/com/otaliastudios/elements/extensions/DataBindingPresenter.kt
@@ -33,6 +33,7 @@ abstract class DataBindingPresenter<T: Any, DB: ViewDataBinding>(
             @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
             fun onDestroy() {
                 binding.setLifecycleOwner(null)
+                lifecycle.removeObserver(this)
             }
         })
         return holder

Original file line number	Diff line number	Diff line change
`@@ -276,6 +276,7 @@ public final class Adapter private constructor(`
`276`	`276`	`it.unbind(this)`
`277`	`277`	`}`
`278`	`278`	`recyclerViews.clear()`
	`279`	`+ lifecycle.removeObserver(this)`
`279`	`280`	`}`
`280`	`281`
`281`	`282`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ abstract class DataBindingPresenter<T: Any, DB: ViewDataBinding>(`
`33`	`33`	`@OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)`
`34`	`34`	`fun onDestroy() {`
`35`	`35`	`binding.setLifecycleOwner(null)`
	`36`	`+ lifecycle.removeObserver(this)`
`36`	`37`	`}`
`37`	`38`	`})`
`38`	`39`	`return holder`