fix: change to not throw when a validator is not of type AttributeValidator (#431)

skirchner989 · web-flow · commit 042f4a912d4b · 2021-01-21T20:06:31.000-08:00
Co-authored-by: Steve Kirchner &lt;skirchner@loopbackanalytics.com&gt;
diff --git a/src/CommandLineUtils/HelpText/DefaultHelpTextGenerator.cs b/src/CommandLineUtils/HelpText/DefaultHelpTextGenerator.cs
@@ -194,7 +194,7 @@ protected virtual void GenerateArguments(
                     var description = arg.Description;
                     var allowedValuesBeenSet = false;
 
-                    foreach (var attributeValidator in arg.Validators.Cast<AttributeValidator>())
+                    foreach (var attributeValidator in arg.Validators.OfType<AttributeValidator>())
                     {
                         if (attributeValidator?.ValidationAttribute is AllowedValuesAttribute allowedValuesAttribute)
                         {
@@ -251,7 +251,7 @@ protected virtual void GenerateOptions(
                     var description = opt.Description;
                     var allowedValuesBeenSet = false;
 
-                    foreach (var attributeValidator in opt.Validators.Cast<AttributeValidator>())
+                    foreach (var attributeValidator in opt.Validators.OfType<AttributeValidator>())
                     {
                         if (attributeValidator?.ValidationAttribute is AllowedValuesAttribute allowedValuesAttribute)
                         {

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ protected virtual void GenerateArguments(`
`194`	`194`	`var description = arg.Description;`
`195`	`195`	`var allowedValuesBeenSet = false;`
`196`	`196`
`197`		`- foreach (var attributeValidator in arg.Validators.Cast<AttributeValidator>())`
	`197`	`+ foreach (var attributeValidator in arg.Validators.OfType<AttributeValidator>())`
`198`	`198`	`{`
`199`	`199`	`if (attributeValidator?.ValidationAttribute is AllowedValuesAttribute allowedValuesAttribute)`
`200`	`200`	`{`
`@@ -251,7 +251,7 @@ protected virtual void GenerateOptions(`
`251`	`251`	`var description = opt.Description;`
`252`	`252`	`var allowedValuesBeenSet = false;`
`253`	`253`
`254`		`- foreach (var attributeValidator in opt.Validators.Cast<AttributeValidator>())`
	`254`	`+ foreach (var attributeValidator in opt.Validators.OfType<AttributeValidator>())`
`255`	`255`	`{`
`256`	`256`	`if (attributeValidator?.ValidationAttribute is AllowedValuesAttribute allowedValuesAttribute)`
`257`	`257`	`{`