Rename to AllowedValuesAttribute

Author: natemcmaster

CHANGELOG.md

@@ -9,7 +9,7 @@ New features:
      - Add the `[FileOrDirectoryExists]` attribute
      - Add the `[DirectoryExists]` attribute
      - Add the `[LegalFilePath]` attribute
-     - Add the `[Values]` attribute
+     - Add the `[AllowedValues]` attribute
   - Added a new, fluent API for validation.
      - Added `Option().Accepts()` and `Argument().Accepts()`
      - Add `.ExistingFile()`

CommandLineUtils.sln

@@ -1,6 +1,6 @@
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
-VisualStudioVersion = 15.0.27130.2010
+VisualStudioVersion = 15.0.27130.2026
 MinimumVisualStudioVersion = 15.0.26124.0
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{95D4B35E-0A21-4D64-8BAF-27DD6C019FC5}"
 EndProject
@@ -25,6 +25,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "files", "files", "{509D6286
 		.licenseheader = .licenseheader
 		build.cmd = build.cmd
 		build.ps1 = build.ps1
+		CHANGELOG.md = CHANGELOG.md
 		Directory.Build.props = Directory.Build.props
 		Directory.Build.targets = Directory.Build.targets
 		LICENSE.txt = LICENSE.txt

samples/Validation/Attributes.cs

@@ -28,7 +28,7 @@ class AttributeProgram
     public string[] Attachments { get; }
 
     [Option]
-    [Values("low", "normal", "high", Comparer = StringComparison.OrdinalIgnoreCase)]
+    [AllowedValues("low", "normal", "high", Comparer = StringComparison.OrdinalIgnoreCase)]
     public string Importance { get; }
 
     [Option(Description = "The colors should be red or blue")]

src/CommandLineUtils/Attributes/ValuesAttribute.cs renamed to src/CommandLineUtils/Attributes/AllowedValuesAttribute.cs

@@ -15,25 +15,25 @@ namespace McMaster.Extensions.CommandLineUtils
     /// </para>
     /// </summary>
     [AttributeUsage(AttributeTargets.Property)]
-    public sealed class ValuesAttribute : ValidationAttribute
+    public sealed class AllowedValuesAttribute : ValidationAttribute
     {
         private readonly string[] _allowedValues;
 
         /// <summary>
-        /// Initializes an instance of <see cref="ValuesAttribute"/>.
+        /// Initializes an instance of <see cref="AllowedValuesAttribute"/>.
         /// </summary>
         /// <param name="allowedValues"></param>
-        public ValuesAttribute(params string[] allowedValues)
+        public AllowedValuesAttribute(params string[] allowedValues)
             : this(StringComparison.CurrentCulture, allowedValues)
         {
         }
 
         /// <summary>
-        /// Initializes an instance of <see cref="ValuesAttribute"/>.
+        /// Initializes an instance of <see cref="AllowedValuesAttribute"/>.
         /// </summary>
         /// <param name="comparer"></param>
         /// <param name="allowedValues"></param>
-        public ValuesAttribute(StringComparison comparer, params string[] allowedValues)
+        public AllowedValuesAttribute(StringComparison comparer, params string[] allowedValues)
             : base(GetDefaultError(allowedValues))
         {
             _allowedValues = allowedValues ?? new string[0];

src/CommandLineUtils/Validation/ValidationExtensions.cs

@@ -160,7 +160,7 @@ public static IValidationBuilder Values(this IValidationBuilder builder, bool ig
         /// <returns>The builder.</returns>
         public static IValidationBuilder Values(this IValidationBuilder builder, StringComparison comparer, params string[] allowedValues)
         {
-            return builder.Satisfies<ValuesAttribute>(ctorArgs: new object[] { comparer, allowedValues });
+            return builder.Satisfies<AllowedValuesAttribute>(ctorArgs: new object[] { comparer, allowedValues });
         }
 
         /// <summary>

test/CommandLineUtils.Tests/ValueAttributeTests.cs renamed to test/CommandLineUtils.Tests/AllowedValuesAttributeTests.cs

@@ -6,19 +6,19 @@
 
 namespace McMaster.Extensions.CommandLineUtils.Tests
 {
-    public class ValueAttributeTests
+    public class AllowedValuesAttributeTests
     {
         private readonly ITestOutputHelper _output;
 
-        public ValueAttributeTests(ITestOutputHelper output)
+        public AllowedValuesAttributeTests(ITestOutputHelper output)
         {
             _output = output;
         }
 
         private class Program
         {
             [Argument(0)]
-            [Values("red", "blue", "green")]
+            [AllowedValues("red", "blue", "green")]
             public string Option { get; }
 
             private void OnExecute() { }
@@ -46,7 +46,7 @@ public void ValidatesValueInSet(string value, bool isValid)
         private class IgnoreCaseProgram
         {
             [Argument(0)]
-            [Values("red", "blue", "green", IgnoreCase = true)]
+            [AllowedValues("red", "blue", "green", IgnoreCase = true)]
             public string Option { get; }
 
             private void OnExecute() { }