fix: update attribute conventions to use TryParse instead of Values.Add

Author: natemcmaster

src/CommandLineUtils/Conventions/ArgumentAttributeConvention.cs

@@ -121,10 +121,13 @@ private void AddArgument(PropertyInfo prop,
                         {
                             if (!ReflectionHelper.IsSpecialValueTupleType(prop.PropertyType, out _))
                             {
-                                if (getter.Invoke(cmd.GetModel()) is IEnumerable<object> value)
+                                if (getter.Invoke(cmd.GetModel()) is IEnumerable<object> values)
                                 {
-                                    argument.Values.AddRange(value.Select(x => x?.ToString()));
-                                    argument.DefaultValue = string.Join(", ", value.Select(x => x?.ToString()));
+                                    foreach (var value in values)
+                                    {
+                                        argument.TryParse(value?.ToString());
+                                    }
+                                    argument.DefaultValue = string.Join(", ", values.Select(x => x?.ToString()));
                                 }
                             }
                         }
@@ -145,11 +148,6 @@ private void AddArgument(PropertyInfo prop,
                         throw new InvalidOperationException(Strings.CannotDetermineParserType(prop));
                     }
 
-                    if (argument.Values.Count == 0)
-                    {
-                        return;
-                    }
-
                     if (r.SelectedCommand is IModelAccessor cmd)
                     {
                         if (argument.Values.Count == 0)
@@ -159,7 +157,7 @@ private void AddArgument(PropertyInfo prop,
                                 var value = getter.Invoke(cmd.GetModel());
                                 if (value != null)
                                 {
-                                    argument.Values.Add(value.ToString());
+                                    argument.TryParse(value.ToString());
                                     argument.DefaultValue = value.ToString();
                                 }
                             }

src/CommandLineUtils/Conventions/OptionAttributeConventionBase.cs

@@ -70,6 +70,7 @@ private protected void AddOption(ConventionContext context, CommandOption option
                         var collectionParser =
                             CollectionParserProvider.Default.GetParser(prop.PropertyType,
                                 context.Application.ValueParsers);
+
                         if (collectionParser == null)
                         {
                             throw new InvalidOperationException(Strings.CannotDetermineParserType(prop));
@@ -79,10 +80,13 @@ private protected void AddOption(ConventionContext context, CommandOption option
                         {
                             if (!ReflectionHelper.IsSpecialValueTupleType(prop.PropertyType, out var type))
                             {
-                                if (getter.Invoke(modelAccessor.GetModel()) is IEnumerable<object> value)
+                                if (getter.Invoke(modelAccessor.GetModel()) is IEnumerable<object> values)
                                 {
-                                    option.Values.AddRange(value.Select(x => x?.ToString()));
-                                    option.DefaultValue = string.Join(", ", value.Select(x => x?.ToString()));
+                                    foreach (var value in values)
+                                    {
+                                        option.TryParse(value?.ToString());
+                                    }
+                                    option.DefaultValue = string.Join(", ", values.Select(x => x?.ToString()));
                                 }
                             }
                         }
@@ -110,7 +114,7 @@ private protected void AddOption(ConventionContext context, CommandOption option
 
                                 if (value != null)
                                 {
-                                    option.Values.Add(value.ToString());
+                                    option.TryParse(value.ToString());
                                     option.DefaultValue = value.ToString();
                                 }
                             }

test/CommandLineUtils.Tests/DefaultHelpTextGeneratorTests.cs

@@ -174,6 +174,7 @@ public void ShowHelpFromAttributes()
             var app = new CommandLineApplication<MyApp>() { Name = "test" };
             app.Conventions.UseDefaultConventions();
             var helpText = GetHelpText(app);
+            _output.WriteLine(helpText);
 
             Assert.Equal(@"Usage: test [options] <SomeStringArgument> <RestrictedStringArgument> <DefaultValStringArgument> <SomeEnumArgument> <RestrictedEnumArgument> <SomeNullableEnumArgument>