fix: don't cancel the ctrl+c event

Fixes #302

Author: natemcmaster

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 [See unreleased changes][unreleased].
 
+## [v2.4.4](https://github.com/natemcmaster/CommandLineUtils/compare/v2.4.3...v2.4.4)
+
+* Fix [#302] - fix regression introduced in 2.4.2 which caused Ctrl+C handling not to terminate the process quickly
+
+[#302]: https://github.com/natemcmaster/CommandLineUtils/issues/302
+
 ## [v2.4.3](https://github.com/natemcmaster/CommandLineUtils/compare/v2.4.2...v2.4.3)
 
 * Fix [#292] by [@thomaslevesque] - fix deadlock when `Environment.Exit` is called

Directory.Build.props

@@ -34,7 +34,7 @@
   </PropertyGroup>
 
    <PropertyGroup>
-    <VersionPrefix>2.4.3</VersionPrefix>
+    <VersionPrefix>2.4.4</VersionPrefix>
     <VersionSuffix>build</VersionSuffix>
     <IncludePreReleaseLabelInPackageVersion Condition="'$(IsStableBuild)' != 'true'">true</IncludePreReleaseLabelInPackageVersion>
     <BuildNumber Condition=" '$(BuildNumber)' == '' ">$(BUILD_NUMBER)</BuildNumber>

src/CommandLineUtils/CommandLineApplication.cs

@@ -876,19 +876,15 @@ public async Task<int> ExecuteAsync(string[] args, CancellationToken cancellatio
                 return command.ValidationErrorHandler(validationResult);
             }
 
-            var handlerCompleted = new ManualResetEventSlim(initialState: false);
             var handlerCancellationTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
 
             void cancelHandler(object o, ConsoleCancelEventArgs e)
             {
                 handlerCancellationTokenSource.Cancel();
-                // Stops the process from exiting forcefully
-                e.Cancel = true;
             }
 
             try
             {
-                // blocks .NET's CTRL+C handler from completing until after async completions are done
                 _context.Console.CancelKeyPress += cancelHandler;
 
                 return await command._handler(handlerCancellationTokenSource.Token);
@@ -900,7 +896,6 @@ void cancelHandler(object o, ConsoleCancelEventArgs e)
             finally
             {
                 _context.Console.CancelKeyPress -= cancelHandler;
-                handlerCompleted.Set();
             }
         }
 

src/CommandLineUtils/releasenotes.props

@@ -16,6 +16,12 @@ Other things I fixed:
 * Add async methods that accept cancellation tokens
 * Handle CTRL+C by default
 * Support calling CommandLineApplication.Execute multiple times
+    </PackageReleaseNotes>
+    <PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.4'">
+$(PackageReleaseNotes)
+
+2.4.4 patch:
+* Fix regression introduced in 2.4.2 which caused Ctrl+C handling not to terminate the process quickly
     </PackageReleaseNotes>
     <PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.3'">
 $(PackageReleaseNotes)