Skip to content

Commit 3c9dcee

Browse files
committed
Stop code signing binaries and packages
1 parent 59781ae commit 3c9dcee

File tree

6 files changed

+1
-87
lines changed

6 files changed

+1
-87
lines changed

.config/dotnet-tools.json

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,11 @@
22
"version": 1,
33
"isRoot": true,
44
"tools": {
5-
"azuresigntool": {
6-
"version": "2.0.17",
7-
"commands": [
8-
"azuresigntool"
9-
]
10-
},
11-
"nugetkeyvaultsigntool": {
12-
"version": "1.2.28",
13-
"commands": [
14-
"NuGetKeyVaultSignTool"
15-
]
16-
},
175
"dotnet-reportgenerator-globaltool": {
186
"version": "4.4.0",
197
"commands": [
208
"reportgenerator"
219
]
2210
}
2311
}
24-
}
12+
}

Directory.Build.props

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@
3434
<Nullable>annotations</Nullable>
3535
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)src\StrongName.snk</AssemblyOriginatorKeyFile>
3636
<SignAssembly>true</SignAssembly>
37-
<AzureKeyVaultUrl>https://nmcmaster.vault.azure.net</AzureKeyVaultUrl>
38-
<AzureKeyVaultClientId>6a27a2da-bb78-4baa-bd2b-150fe89ea039</AzureKeyVaultClientId>
39-
<AzureKeyVaultClientSecret>$(KEYVAULT_CLIENT_SECRET)</AzureKeyVaultClientSecret>
40-
<CodeSignCertName>DigiCertCodeSign</CodeSignCertName>
4137

4238
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
4339
<GenerateFullPaths Condition="'$(TERM_PROGRAM)' == 'vscode'">true</GenerateFullPaths>

azure-pipelines.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ pr:
1010
- '*'
1111

1212
variables:
13-
- group: AzureKeyVault
1413
- name: BUILD_NUMBER
1514
value: $[counter('buildnumber', 1)]
1615

@@ -39,8 +38,6 @@ jobs:
3938
packageType: runtime
4039
- powershell: ./build.ps1 -ci
4140
displayName: Invoke build.ps1
42-
env:
43-
KEYVAULT_CLIENT_SECRET: $(kv-access-token)
4441
- task: PublishTestResults@2
4542
displayName: Publish test results
4643
condition: always()

build.ps1

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ param(
55
$Configuration = $null,
66
[switch]
77
$ci,
8-
[switch]
9-
$sign,
108
[Parameter(ValueFromRemainingArguments = $true)]
119
[string[]]$MSBuildArgs
1210
)
@@ -39,12 +37,6 @@ if (-not (Test-Path variable:\IsCoreCLR)) {
3937
$IsWindows = $true
4038
}
4139

42-
$CodeSign = $sign -or ($ci -and -not $isPr -and $IsWindows)
43-
44-
if ($CodeSign) {
45-
$MSBuildArgs += '-p:CodeSign=true'
46-
}
47-
4840
$artifacts = "$PSScriptRoot/artifacts/"
4941

5042
Remove-Item -Recurse $artifacts -ErrorAction Ignore

src/CodeSign.targets

Lines changed: 0 additions & 57 deletions
This file was deleted.

src/Directory.Build.targets

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,4 @@
1414
<Message Importance="High" Text="##vso[build.updatebuildnumber]$(PackageVersion)" />
1515
</Target>
1616

17-
<Import Project="CodeSign.targets" />
18-
1917
</Project>

0 commit comments

Comments
 (0)