Fix #30 - fix help text when OptionAttribute.ShortName is specified

Author: natemcmaster

src/CommandLineUtils/Attributes/OptionAttribute.cs

@@ -82,13 +82,6 @@ internal CommandOption Configure(CommandLineApplication app, PropertyInfo prop)
                     ShortName = longName.Substring(0, 1),
                     ValueName = prop.Name.ToConstantCase(),
                 };
-
-                option.Template = $"-{option.ShortName}|--{option.LongName}";
-
-                if (option.OptionType != CommandOptionType.NoValue)
-                {
-                    option.Template += $" <{option.ValueName.ToConstantCase()}>";
-                }
             }
 
             Configure(option);

src/CommandLineUtils/Attributes/OptionAttributeBase.cs

@@ -61,6 +61,11 @@ internal void Configure(CommandOption option)
             option.LongName = LongName ?? option.LongName;
             option.ValueName = ValueName ?? option.ValueName;
             option.SymbolName = SymbolName ?? option.SymbolName;
+
+            if (option.Template == null)
+            {
+                option.Template = option.ToTemplateString();
+            }
         }
     }
 }

src/CommandLineUtils/CommandOption.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Text;
 using McMaster.Extensions.CommandLineUtils.Validation;
 
 namespace McMaster.Extensions.CommandLineUtils
@@ -175,6 +176,40 @@ public string Value()
             return HasValue() ? Values[0] : null;
         }
 
+        /// <summary>
+        /// Generates the template string in the format "-{Symbol}|-{Short}|--{Long} &lt;{Value}&gt;" for display in help text.
+        /// </summary>
+        /// <returns>The template string</returns>
+        internal string ToTemplateString()
+        {
+            var sb = new StringBuilder();
+            if (SymbolName != null)
+            {
+                sb.Append('-').Append(SymbolName);
+            }
+
+            if (ShortName != null)
+            {
+                if (sb.Length > 0) sb.Append('|');
+
+                sb.Append('-').Append(ShortName);
+            }
+
+            if (LongName != null)
+            {
+                if (sb.Length > 0) sb.Append('|');
+
+                sb.Append("--").Append(LongName);
+            }
+
+            if (ValueName != null && OptionType != CommandOptionType.NoValue)
+            {
+                sb.Append(" <").Append(ValueName).Append('>');
+            }
+
+            return sb.ToString();
+        }
+
         private bool IsEnglishLetter(char c)
         {
             return (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z');

test/CommandLineUtils.Tests/ReflectionAppBuilderTests.cs

@@ -3,9 +3,11 @@
 
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Reflection;
 using System.Reflection.Emit;
+using System.Text;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -122,8 +124,11 @@ public void CanOverrideShortNameOnOption()
         {
             var builder = new ReflectionAppBuilder<ShortNameOverride>();
             builder.Initialize();
-            Assert.Contains(builder.App.Options, o => o.ShortName == "d1" && o.LongName == "detail1");
-            Assert.Contains(builder.App.Options, o => o.ShortName == "d2" && o.LongName == "detail2");
+
+            var d1 = Assert.Single(builder.App.Options, o => o.ShortName == "d1");
+            Assert.Equal("-d1|--detail1 <DETAIL1>", d1.Template);
+            var d2 = Assert.Single(builder.App.Options, o => o.ShortName == "d2");
+            Assert.Equal("-d2|--detail2 <DETAIL2>", d2.Template);
         }
 
         private class AmbiguousShortOptionName