Skip to content

Commit b9eb55b

Browse files
authored
fix: set UsePagerForHelpText to false by default (#347)
1 parent 53e19fc commit b9eb55b

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

CHANGELOG.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
[Unreleased changes](https://github.com/natemcmaster/CommandLineUtils/compare/v2.5.1...HEAD):
44

5-
## [v2.6.0](https://github.com/natemcmaster/CommandLineUtils/compare/v2.5.1...v2.6.0)
5+
### Changes
66

7-
* Refactor: obsolete throwOnUnexpectedArg in favor of UnrecognizedArgumentHandling. See https://github.com/natemcmaster/CommandLineUtils/issues/339 for details
7+
* Disabled the pager for help text by default. To re-enable, set UsePagerForHelpText = true. ([#346])
88

99
### Breaking changes
1010

@@ -18,6 +18,11 @@
1818
[#251]: https://github.com/natemcmaster/CommandLineUtils/issues/251
1919
[#294]: https://github.com/natemcmaster/CommandLineUtils/issues/294
2020
[#337]: https://github.com/natemcmaster/CommandLineUtils/issues/337
21+
[#346]: https://github.com/natemcmaster/CommandLineUtils/issues/346
22+
23+
## [v2.6.0](https://github.com/natemcmaster/CommandLineUtils/compare/v2.5.1...v2.6.0)
24+
25+
* Refactor: obsolete throwOnUnexpectedArg in favor of UnrecognizedArgumentHandling. See https://github.com/natemcmaster/CommandLineUtils/issues/339 for details
2126

2227
## [v2.5.1](https://github.com/natemcmaster/CommandLineUtils/compare/v2.5.0...v2.5.1)
2328

src/CommandLineUtils/Attributes/CommandAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public string? Name
120120
/// <summary>
121121
/// Whether a Pager should be used to display help text.
122122
/// </summary>
123-
public bool UsePagerForHelpText { get; set; } = true;
123+
public bool UsePagerForHelpText { get; set; } = false;
124124

125125
/// <summary>
126126
/// <para>

src/CommandLineUtils/CommandLineApplication.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ internal CommandLineApplication(
124124
ValueParsers = parent?.ValueParsers ?? new ValueParserProvider();
125125
_parserConfig = parent?._parserConfig ?? new ParserConfig();
126126
_clusterOptions = parent?._clusterOptions;
127-
UsePagerForHelpText = parent?.UsePagerForHelpText ?? true;
127+
UsePagerForHelpText = parent?.UsePagerForHelpText ?? false;
128128

129129
_conventionContext = CreateConventionContext();
130130

src/CommandLineUtils/PublicAPI.Shipped.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ McMaster.Extensions.CommandLineUtils.CommandAttribute.OptionsComparison.get -> S
8888
McMaster.Extensions.CommandLineUtils.CommandAttribute.OptionsComparison.set -> void
8989
McMaster.Extensions.CommandLineUtils.CommandAttribute.ParseCulture.get -> System.Globalization.CultureInfo
9090
McMaster.Extensions.CommandLineUtils.CommandAttribute.ParseCulture.set -> void
91-
McMaster.Extensions.CommandLineUtils.CommandAttribute.UsePagerForHelpText.get -> bool
92-
McMaster.Extensions.CommandLineUtils.CommandAttribute.UsePagerForHelpText.set -> void
9391
McMaster.Extensions.CommandLineUtils.CommandAttribute.ResponseFileHandling.get -> McMaster.Extensions.CommandLineUtils.ResponseFileHandling
9492
McMaster.Extensions.CommandLineUtils.CommandAttribute.ResponseFileHandling.set -> void
9593
McMaster.Extensions.CommandLineUtils.CommandAttribute.ShowInHelpText.get -> bool

src/CommandLineUtils/PublicAPI.Unshipped.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
McMaster.Extensions.CommandLineUtils.CommandAttribute.UsePagerForHelpText.get -> bool
2+
McMaster.Extensions.CommandLineUtils.CommandAttribute.UsePagerForHelpText.set -> void
13
McMaster.Extensions.CommandLineUtils.CommandAttribute.UnrecognizedArgumentHandling.set -> void
24
McMaster.Extensions.CommandLineUtils.CommandAttribute.UnrecognizedArgumentHandling.get -> McMaster.Extensions.CommandLineUtils.UnrecognizedArgumentHandling
35
McMaster.Extensions.CommandLineUtils.CommandLineApplication.CommandLineApplication(McMaster.Extensions.CommandLineUtils.HelpText.IHelpTextGenerator helpTextGenerator, McMaster.Extensions.CommandLineUtils.IConsole console, string workingDirectory) -> void

0 commit comments

Comments
 (0)