Should we fail when an exception is thrown during the rendering?

[oliviertassinari]

I have come up in that situation by updating the package.json:

- "jss-theme-reactor": "^0.10.0",
+ "jss-theme-reactor": "^0.11.1",

By situation I mean a rendering almost 100% broken.

That also lead to another side effect, the following tests was outputting a blank screenshot:

// @flow weak

import React from 'react';
import Checkbox from 'material-ui/Checkbox';

export default function CheckedCheckbox() {
  return <Checkbox checked />;
}

later crashing the vrtests:

regression-Checkbox
events.js:160
throw er; // Unhandled 'error' event
^

TypeError: argument should be a Buffer
at Function.PNG.bitblt (/Users/oliviertassinari/material-ui-next/node_modules/pngjs/lib/png.js:129:14)
at exports.PNG.PNG.bitblt (/Users/oliviertassinari/material-ui-next/node_modules/pngjs/lib/png.js:140:7)
at exports.PNG. (/Users/oliviertassinari/material-ui-next/node_modules/png-crop/index.js:49:12)
at emitOne (events.js:96:13)
at exports.PNG.emit (events.js:188:7)
at exports.PNG. (/Users/oliviertassinari/material-ui-next/node_modules/pngjs/lib/png.js:36:10)
at emitOne (events.js:96:13)
at module.exports.emit (events.js:188:7)
at module.exports.ParserAsync._complete (/Users/oliviertassinari/material-ui-next/node_modules/pngjs/lib/parser-async.js:109:8)
at emitOne (events.js:96:13)
error Command failed with exit code 7.

Logs of the docker:

chrome_1 | 19:35:39.433 INFO - Executing: [get window size])
chrome_1 | 19:35:39.445 INFO - Done: [get window size]
chrome_1 | 19:35:39.460 INFO - Executing: [take screenshot])
chrome_1 | 19:35:39.519 INFO - Done: [take screenshot]