Merge remote-tracking branch 'upstream/main' into merge_main

Author: bartlomieju

.custom-gcl.yml

@@ -1,6 +1,6 @@
 # yaml-language-server: $schema=https://golangci-lint.run/jsonschema/custom-gcl.jsonschema.json
 
-version: v2.5.0
+version: v2.6.2
 
 destination: ./_tools
 

.devcontainer/devcontainer.json

@@ -1,12 +1,21 @@
 // For format details, see https://aka.ms/devcontainer.json. For config options, see the
-// README at: https://github.com/devcontainers/templates/tree/main/src/universal
+// README at: https://github.com/devcontainers/templates/tree/main/src/go
 {
     "name": "TypeScript Compiler Development",
     // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
-    "image": "mcr.microsoft.com/devcontainers/universal:2-linux",
-
+    "image": "mcr.microsoft.com/devcontainers/go:2-1.25-bookworm",
     // Features to add to the dev container. More info: https://containers.dev/features.
-    // "features": {},
+    "features": {
+        "ghcr.io/devcontainers/features/node:1": {
+            "version": "lts",
+            "pnpmVersion": "latest",
+            "nvmVersion": "latest"
+        },
+        "ghcr.io/devcontainers-extra/features/dprint-asdf:2": {
+            "version": "latest"
+        },
+        "ghcr.io/devcontainers/features/rust:1": {}
+    },
 
     // Use 'forwardPorts' to make a list of ports inside the container available locally.
     // "forwardPorts": [],

.dprint.jsonc

@@ -58,8 +58,8 @@
     // Note: if adding new languages, make sure settings.template.json is updated too.
     // Also, if updating typescript, update the one in package.json.
     "plugins": [
-        "https://plugins.dprint.dev/typescript-0.95.11.wasm",
-        "https://plugins.dprint.dev/json-0.20.0.wasm",
+        "https://plugins.dprint.dev/typescript-0.95.12.wasm",
+        "https://plugins.dprint.dev/json-0.21.0.wasm",
         "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.1.wasm",
         "https://plugins.dprint.dev/exec-0.6.0.json@a054130d458f124f9b5c91484833828950723a5af3f8ff2bd1523bd47b83b364"
     ]

.github/ISSUE_TEMPLATE/02-behavior-difference.md

@@ -1,6 +1,6 @@
 ---
 name: Behavior Difference
-about: tsgo produces different results than TypeScript 5.8
+about: tsgo produces different results than TypeScript 5.9
 title: ''
 labels: ''
 assignees: ''
@@ -11,6 +11,6 @@ assignees: ''
 
 <!-- Share a repository link or a code sample -->
 
-## Behavior with `typescript@5.8`
+## Behavior with `typescript@5.9`
 
 ## Behavior with `tsgo`

.github/ISSUE_TEMPLATE/03-vscode-editor-issue.yml

@@ -0,0 +1,48 @@
+name: 'VS Code Editor Issue'
+description: 'Issue using tsgo in VS Code'
+labels: 'Domain: Editor'
+assignees: []
+body:
+  - type: input
+    id: extension_version
+    attributes:
+      label: Extension Version
+      description: The version of the TypeScript (native preview) extension
+      placeholder: '0.20251016.x'
+    validations:
+      required: true
+  - type: input
+    id: vscode_version
+    attributes:
+      label: VS Code Version
+      description: The version of the VS Code you are using
+      placeholder: '1.105.x'
+    validations:
+      required: true
+  - type: input
+    id: os_version
+    attributes:
+      label: Operating system Version
+      description: Your operating system and version
+    validations:
+      required: true
+  - type: textarea
+    id: steps
+    attributes:
+      label: 'Steps to reproduce'
+      description: |
+        Information about how to reproduce the issue and expected behavior
+      value: |
+        1.
+        2.
+        3.
+    validations:
+      required: true
+  - type: textarea
+    id: bug_info
+    attributes:
+      label: 'Issue'
+      description: |
+        Information about the bug, such as expected vs actual behavior
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/03-other.md .github/ISSUE_TEMPLATE/04-other.md.github/ISSUE_TEMPLATE/03-other.md renamed to .github/ISSUE_TEMPLATE/04-other.md

@@ -3,8 +3,8 @@ description: Setup Go
 
 inputs:
   go-version:
-    description: Go version range to set up.
-    default: '>=1.25.0'
+    description: Go version to set up in go-install.ps1 format
+    default: 'go1.25'
   create:
     description: Create the cache
     default: 'false'
@@ -18,19 +18,51 @@ runs:
   steps:
     - name: Install Go
       id: install-go
-      uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
-      with:
-        go-version: ${{ inputs.go-version }}
-        cache: false
+      shell: pwsh
+      run: |
+        # https://github.com/microsoft/go-infra/blob/main/goinstallscript/powershell/go-install.ps1
+        ${{ github.action_path }}/go-install.ps1 -Version ${{ inputs.go-version }} -GitHubActionsPath
+
+        $goVersionOutput = go version
+        Write-Host $goVersionOutput
+        # Extract version like "1.23.4" from "go version go1.23.4 windows/amd64"
+        if ($goVersionOutput -match 'go version go([\d\.]+)') {
+          $exactVersion = $matches[1]
+          "go-version=$exactVersion" >> $env:GITHUB_OUTPUT
+          Write-Host "Exact Go version: $exactVersion"
+        } else {
+          Write-Error "Failed to parse Go version from: $goVersionOutput"
+          exit 1
+        }
+
+    - name: Verify Microsoft Go
+      shell: pwsh
+      run: |
+        $goPath = (Get-Command go).Source
+        Write-Host "Go executable path: $goPath"
+        if ($goPath -notlike "*microsoft-go*") {
+          Write-Error "Go installation is not from microsoft-go. Path: $goPath"
+          exit 1
+        }
+        Write-Host "✓ Verified: Microsoft Go is active"
+
+    - name: Add GOBIN to PATH
+      shell: bash
+      run: |
+        GOBIN=$(go env GOBIN)
+        if [ -z "$GOBIN" ]; then
+          GOBIN="$(go env GOPATH)/bin"
+        fi
+        echo "$GOBIN" >> $GITHUB_PATH
 
     # Avoid hardcoding the cache keys more than once.
     - name: Get cache info
       shell: bash
       id: cache-info
       env:
-        MODULES_KEY: go-modules-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
-        LINT_KEY: golangci-lint-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
-        BUILD_KEY: go-build-cache-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}
+        MODULES_KEY: go-modules-${{ runner.os }}-msft-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
+        LINT_KEY: golangci-lint-${{ runner.os }}-msft-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
+        BUILD_KEY: go-build-cache-${{ runner.os }}-msft-${{ steps.install-go.outputs.go-version }}
       run: |
         echo "modules-key=$MODULES_KEY" >> $GITHUB_OUTPUT
         echo "lint-key=$LINT_KEY" >> $GITHUB_OUTPUT