fix: isConnected should not throw if device is not connected but return false

Author: farfromrefug

src/bluetooth.android.ts

@@ -1394,23 +1394,18 @@ export class Bluetooth extends BluetoothCommon {
 
     @bluetoothEnabled
     @prepareArgs
-    public isConnected(args) {
+    public async isConnected(args) {
         const methodName = 'isConnected';
         // TODO: no try catch for now as we rely on our own connections state object.
         // try {
         if (!args.UUID) {
-            return Promise.reject(new BluetoothError(BluetoothCommon.msg_missing_parameter, { type: BluetoothCommon.UUIDKey, method: methodName }));
+            throw new BluetoothError(BluetoothCommon.msg_missing_parameter, { type: BluetoothCommon.UUIDKey, method: methodName });
         }
         const stateObject = this.connections[args.UUID];
         if (!stateObject) {
-            return Promise.reject(
-                new BluetoothError(BluetoothCommon.msg_peripheral_not_connected, {
-                    method: methodName,
-                    arguments: args,
-                })
-            );
+            return false;
         }
-        return Promise.resolve(stateObject.state === 'connected');
+        return stateObject.state === 'connected';
     }
 
     public openBluetoothSettings() {

src/bluetooth.ios.ts

@@ -1098,45 +1098,37 @@ export class Bluetooth extends BluetoothCommon {
 
     @bluetoothEnabled
     @prepareArgs
-    public isConnected(args) {
+    public async isConnected(args) {
         const methodName = 'isConnected';
         try {
             if (!args.UUID) {
-                return Promise.reject(
-                    new BluetoothError(BluetoothCommon.msg_missing_parameter, {
-                        method: methodName,
-                        type: BluetoothCommon.UUIDKey,
-                        arguments: args,
-                    })
-                );
+                throw new BluetoothError(BluetoothCommon.msg_missing_parameter, {
+                    method: methodName,
+                    type: BluetoothCommon.UUIDKey,
+                    arguments: args,
+                });
+
             }
             const peripheral = this.findPeripheral(args.UUID);
             if (peripheral === null) {
-                return Promise.reject(
-                    new BluetoothError(BluetoothCommon.msg_no_peripheral, {
-                        method: methodName,
-                        arguments: args,
-                    })
-                );
+                return false;
             } else {
                 if (Trace.isEnabled()) {
                     CLog(CLogTypes.info, methodName, '---- checking connection with peripheral UUID:', args.UUID);
                 }
-                return Promise.resolve(peripheral.state === CBPeripheralState.Connected);
+                return peripheral.state === CBPeripheralState.Connected;
             }
         } catch (ex) {
             if (Trace.isEnabled()) {
                 CLog(CLogTypes.error, methodName, '---- error:', ex);
             }
 
-            return Promise.reject(
-                new BluetoothError(ex.message, {
-                    stack: ex.stack,
-                    nativeException: ex.nativeException,
-                    method: methodName,
-                    arguments: args,
-                })
-            );
+            throw new BluetoothError(ex.message, {
+                stack: ex.stack,
+                nativeException: ex.nativeException,
+                method: methodName,
+                arguments: args,
+            });
         }
     }