fix(ios): test for gesture activation on first touch like Android

Author: farfromrefug

packages/gesturehandler/platforms/ios/src/GestureHandler.h

@@ -78,6 +78,7 @@ if (value != nil) recognizer.prop = [value type]; \
 //@property (nonatomic, weak, nullable) id<GestureHandlerEventEmitter> emitter;
 @property (nonatomic, readonly, nullable) UIGestureRecognizer *recognizer;
 @property (nonatomic) BOOL enabled;
+@property (nonatomic) BOOL activateOnBegin;
 @property(nonatomic) BOOL shouldCancelWhenOutside;
 @property (nullable, nonatomic, weak) id<GestureHandlerDelegate> delegate;
 

packages/gesturehandler/platforms/ios/src/GestureHandler.m

@@ -70,6 +70,7 @@ - (instancetype)initWithTag:(NSNumber *)tag
         _tag = tag;
         _lastState = GestureHandlerStateUndetermined;
         _hitSlop = RNGHHitSlopEmpty;
+        _activateOnBegin = YES;
     }
     return self;
 }
@@ -323,7 +324,7 @@ - (BOOL)containsPointInView
 - (BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer
 {
     [self reset];
-    if (self.delegate && [self.delegate respondsToSelector:@selector(gestureHandler:shouldActivateForEvent:)]) {
+    if (self.activateOnBegin && self.delegate && [self.delegate respondsToSelector:@selector(gestureHandler:shouldActivateForEvent:)]) {
         if (![self.delegate gestureHandler:self shouldActivateForEvent:[self eventExtraData:gestureRecognizer]]) {
           return FALSE;
         }

packages/gesturehandler/platforms/ios/src/PanHandler.m

@@ -79,6 +79,12 @@ - (void)touchesBegan:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
   }
 #endif
   [super touchesBegan:touches withEvent:event];
+
+  // we check for active before UIGestureRecognizerStateBegan because otherwise
+  // we dont behave as Android and activate on first touch
+  if (![_gestureHandler.delegate gestureHandler:_gestureHandler shouldActivateForEvent:[_gestureHandler eventExtraData:self]]) {
+    self.state = UIGestureRecognizerStateFailed;
+  }
 }
 
 - (void)touchesMoved:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
@@ -187,6 +193,7 @@ - (instancetype)initWithTag:(NSNumber *)tag
 {
   if ((self = [super initWithTag:tag])) {
     _recognizer = [[BetterPanGestureRecognizer alloc] initWithGestureHandler:self];
+    self.activateOnBegin = NO;
   }
   return self;
 }
@@ -275,4 +282,3 @@ - (void)setFailOffsetYEnd:(CGFloat)value {
   ((BetterPanGestureRecognizer*)_recognizer).failOffsetYEnd = value;
 }
 @end
-