Skip to content

Commit dcd430a

Browse files
committed
fix: ensure we release all callbacks (N gesture override)
1 parent 8c03991 commit dcd430a

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/gesturehandler/gestures_override.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import { Handler, Manager } from './gesturehandler';
55
import { GestureHandlerStateEvent, GestureHandlerTouchEvent, GestureState, GestureStateEventData, HandlerType, ROOT_GESTURE_HANDLER_TAG } from './gesturehandler.common';
66

77
export function observe(target: View, type: GestureTypes, callback: (args: GestureEventData) => void, context?: any): GesturesObserver {
8+
if (!callback) {
9+
return;
10+
}
811
const observer = new GesturesObserver(target, callback, context);
912
observer.observe(type);
1013
return observer;
@@ -123,6 +126,8 @@ export class GesturesObserver {
123126

124127
private _detach() {
125128
if (this.gestureHandler) {
129+
this.gestureHandler.off(GestureHandlerStateEvent);
130+
this.gestureHandler.off(GestureHandlerTouchEvent);
126131
this.gestureHandler.detachFromView(this.target);
127132
// delete this.target._gestureHandlers[this.type];
128133
}

0 commit comments

Comments
 (0)