fix: get appPath only once

Instead of calculating the app path on each path transform, set it only once - when the debugger is attaching.

Author: rosen-vladimirov

src/debug-adapter/nativeScriptDebugAdapter.ts

@@ -1,3 +1,5 @@
+import { existsSync, readFileSync } from 'fs';
+import { join } from 'path';
 import { ChromeDebugAdapter, IRestartRequestArgs } from 'vscode-chrome-debug-core';
 import { Event, TerminatedEvent } from 'vscode-debugadapter';
 import { DebugProtocol } from 'vscode-debugprotocol';
@@ -108,14 +110,31 @@ export class NativeScriptDebugAdapter extends ChromeDebugAdapter {
             this._session.sendEvent(new TerminatedEvent());
         }
 
-        (this.pathTransformer as any).setTargetPlatform(args.platform);
+        const appDirPath = this.getAppDirPath(transformedArgs.webRoot);
+
+        (this.pathTransformer as any).setTransformOptions(args.platform, appDirPath);
         (ChromeDebugAdapter as any).SET_BREAKPOINTS_TIMEOUT = 20000;
 
         this.isLiveSync = args.watch;
 
         return super.attach(transformedArgs);
     }
 
+    private getAppDirPath(webRoot: string): string {
+        const pathToNsconfig = join(webRoot, 'nsconfig.json');
+
+        if (existsSync(pathToNsconfig)) {
+            try {
+                const content = readFileSync(pathToNsconfig).toString();
+                const jsonContent = JSON.parse(content);
+
+                return jsonContent.appPath;
+            } catch (err) {
+                // Ignore the error for the moment
+            }
+        }
+    }
+
     private translateArgs(args): any {
         if (args.diagnosticLogging) {
             args.trace = args.diagnosticLogging;

src/debug-adapter/nativeScriptPathTransformer.ts

@@ -10,9 +10,11 @@ export class NativeScriptPathTransformer extends UrlPathTransformer {
     };
 
     private targetPlatform: string;
+    private appDirPath: string;
 
-    public setTargetPlatform(targetPlatform: string) {
+    public setTransformOptions(targetPlatform: string, appDirPath: string) {
         this.targetPlatform = targetPlatform.toLowerCase();
+        this.appDirPath = appDirPath;
     }
 
     protected async targetUrlToClientPath(webRoot: string, scriptUrl: string): Promise<string> {
@@ -42,19 +44,8 @@ export class NativeScriptPathTransformer extends UrlPathTransformer {
 
         relativePath = relativePath.replace('tns_modules', nodePath);
 
-        const pathToNsconfig = path.join(webRoot, 'nsconfig.json');
-
-        if (fs.existsSync(pathToNsconfig)) {
-            try {
-                const content = fs.readFileSync(pathToNsconfig).toString();
-                const jsonContent = JSON.parse(content);
-
-                if (jsonContent.appPath) {
-                    relativePath = relativePath.replace('app', jsonContent.appPath);
-                }
-            } catch (err) {
-                // Ignore the error for the moment
-            }
+        if (this.appDirPath) {
+            relativePath = relativePath.replace('app', this.appDirPath);
         }
 
         const absolutePath = path.resolve(path.join(webRoot, relativePath));

src/tests/nativeScriptDebugAdapter.tests.ts

@@ -58,7 +58,7 @@ describe('NativeScriptDebugAdapter', () => {
         pathTransformerMock = {
             attach: () => ({}),
             clearTargetContext: () => ({}),
-            setTargetPlatform: () => ({}),
+            setTransformOptions: () => ({}),
         };
 
         nativeScriptDebugAdapter = new NativeScriptDebugAdapter(
@@ -84,8 +84,8 @@ describe('NativeScriptDebugAdapter', () => {
                 sinon.assert.calledWith(spy, sinon.match({ event: extProtocol.BEFORE_DEBUG_START }));
             });
 
-            it(`${method} for ${platform} should call project setTargetPlatform`, async () => {
-                const spy = sinon.spy(pathTransformerMock, 'setTargetPlatform');
+            it(`${method} for ${platform} should call project setTransformOptions`, async () => {
+                const spy = sinon.spy(pathTransformerMock, 'setTransformOptions');
 
                 await nativeScriptDebugAdapter[method](argsMock);
 

src/tests/nativeScriptPathTransformer.tests.ts

@@ -8,7 +8,6 @@ import * as tests from './pathTransformData';
 describe('NativeScriptPathTransformer', () => {
     let nativeScriptPathTransformer: any;
     let existsSyncStub;
-    let readFileSyncStub;
 
     before(() => {
         nativeScriptPathTransformer = new NativeScriptPathTransformer();
@@ -23,17 +22,11 @@ describe('NativeScriptPathTransformer', () => {
             it(`should transform [${test.platform}] device path ${test.scriptUrl} -> ${test.expectedResult}${nsConfigPartInTestName}`, async () => {
                 (path as any).join = path.win32.join;
                 (path as any).resolve = path.win32.resolve;
-                (path as any).basename = path.win32.basename;
-                nativeScriptPathTransformer.setTargetPlatform(test.platform);
-                const isNsconfigFilePath = (filePath: string) => path.basename(filePath) === 'nsconfig.json';
+                nativeScriptPathTransformer.setTransformOptions(test.platform, test.nsconfig ? test.nsconfig.appPath : null);
 
                 existsSyncStub = sinon
                     .stub(fs, 'existsSync')
-                    .callsFake((arg: string) => arg === test.existingPath || (test.nsconfig && isNsconfigFilePath(arg)));
-                readFileSyncStub = sinon
-                    .stub(fs, 'readFileSync')
-                    .callsFake((filePath: string) => (isNsconfigFilePath(filePath) && test.nsconfig) ? JSON.stringify(test.nsconfig) : null);
-
+                    .callsFake((arg: string) => arg === test.existingPath);
                 const result = await nativeScriptPathTransformer.targetUrlToClientPath(webRoot, test.scriptUrl);
 
                 assert.equal(result, test.expectedResult);
@@ -42,7 +35,6 @@ describe('NativeScriptPathTransformer', () => {
 
         afterEach(() => {
             existsSyncStub.restore();
-            readFileSyncStub.restore();
         });
     });