Skip to content

Commit ba2b299

Browse files
committed
Merge branch 'alpimaps' of github.com:farfromrefug/nativescript-carto into alpimaps
2 parents ca6d070 + 484f1d9 commit ba2b299

File tree

8 files changed

+15699
-19
lines changed

8 files changed

+15699
-19
lines changed

packages/ui-carto/platforms/android/java/com/akylas/carto/additions/AKRoutingServiceAdditions.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,18 @@ enum RoutingAction {
4545
static final String TAG = "AKRoutingServiceAdditions";
4646
static Handler mainHandler = null;
4747

48-
public static void calculateRoute (final RoutingService service, final RoutingRequest request, final String profile, final Boolean stringify, final RoutingServiceRouteCallback callback) {
48+
public static void calculateRoute (final RoutingService service, final RoutingRequest request, final String profile, final boolean stringify, final RoutingServiceRouteCallback callback) {
4949
Thread thread = new Thread(new Runnable() {
5050
@Override
5151
public void run() {
5252
RoutingResult result = null;
53+
String strResult = null;
5354
try {
5455
service.setProfile(profile);
5556
result = service.calculateRoute(request);
57+
if (stringify) {
58+
strResult = stringifyRoutingResult(result);
59+
}
5660
} catch (final Exception e) {
5761
e.printStackTrace();
5862
if (AKMapView.RUN_ON_MAIN_THREAD) {
@@ -72,7 +76,7 @@ public void run() {
7276
}
7377

7478
final RoutingResult fRa = result;
75-
final String fStrResult = stringify ? stringifyRoutingResult(result) : null;
79+
final String fStrResult = strResult;
7680
if (AKMapView.RUN_ON_MAIN_THREAD) {
7781
if (mainHandler == null) {
7882
mainHandler = new Handler(android.os.Looper.getMainLooper());

src/ui-carto/rastertiles/index.ios.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@ import { MapPos, toNativeMapPos } from '../core';
44
import { FeatureCollection, VectorTileFeatureCollection } from '../geometry/feature';
55
import { MapBoxElevationDataDecoderOptions, TerrariumElevationDataDecoderOptions } from '.';
66

7-
export class MapBoxElevationDataDecoder extends BaseNative<com.carto.rastertiles.MapBoxElevationDataDecoder, MapBoxElevationDataDecoderOptions> {
7+
export class MapBoxElevationDataDecoder extends BaseNative<NTMapBoxElevationDataDecoder, MapBoxElevationDataDecoderOptions> {
88
createNative(options: MapBoxElevationDataDecoderOptions) {
9-
return new NTMapBoxElevationDataDecoder();
9+
return NTMapBoxElevationDataDecoder.new();
1010
}
1111
public getElevation(pos: MapPos) {}
1212
}
1313

14-
export class TerrariumElevationDataDecoder extends BaseNative<com.carto.rastertiles.TerrariumElevationDataDecoder, TerrariumElevationDataDecoderOptions> {
14+
export class TerrariumElevationDataDecoder extends BaseNative<NTTerrariumElevationDataDecoder, TerrariumElevationDataDecoderOptions> {
1515
createNative(options: TerrariumElevationDataDecoderOptions) {
16-
return NTTerrariumElevationDataDecoder.alloc.init();
16+
return NTTerrariumElevationDataDecoder.new();
1717
}
1818
public getElevation(pos: MapPos) {}
1919
}

src/ui-carto/search/index.ios.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ export class VectorTileSearchService extends BaseNative<AKVectorTileSearchServic
3434
nRequest.setGeometry(geometryFromArgs(options.geometry));
3535
}
3636
if (callback) {
37-
this.getNative().findFeaturesCallback(nRequest, (r)=>new VectorTileFeatureCollection(r))
37+
this.getNative().findFeaturesCallback(nRequest, (r) => new VectorTileFeatureCollection(r));
38+
return null;
3839
} else {
39-
return new VectorTileFeatureCollection(this.getNative().findFeatures(nRequest));
40+
return new VectorTileFeatureCollection(this.getNative().findFeatures(nRequest));
4041
}
4142
}
4243
set layers(value: string | string[]) {
@@ -75,9 +76,10 @@ export class FeatureCollectionSearchService extends BaseNative<AKFeatureCollecti
7576
}
7677
}
7778
if (callback) {
78-
this.getNative().findFeaturesCallback(nRequest, (r)=>new FeatureCollection(r))
79+
this.getNative().findFeaturesCallback(nRequest, (r) => new FeatureCollection(r));
80+
return null;
7981
} else {
80-
return new FeatureCollection(this.getNative().findFeatures(nRequest));
82+
return new FeatureCollection(this.getNative().findFeatures(nRequest));
8183
}
8284
}
8385
}

src/ui-carto/ui/index.android.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ import { MapOptions } from '.';
3333
import { EPSG4326 } from '../projections/epsg4326';
3434
export { MapClickedEvent, MapIdleEvent, MapMovedEvent, MapReadyEvent, MapStableEvent, setLicenseKeyRegistered };
3535

36-
export const time = global.__time || Date.now;
37-
3836
export const RenderProjectionMode = {
3937
get RENDER_PROJECTION_MODE_PLANAR() {
4038
return com.carto.components.RenderProjectionMode.RENDER_PROJECTION_MODE_PLANAR;
@@ -300,11 +298,15 @@ export class CartoMap<T = DefaultLatLonKeys> extends CartoViewBase {
300298
if (this.mapView) {
301299
const native: com.carto.layers.TileLayer = layer.getNative();
302300
if (!!native) {
303-
const layers = this.mapView.getLayers();
304-
if (index !== undefined && index < layers.count()) {
305-
layers.insert(index, native);
306-
} else {
307-
layers.add(native);
301+
try {
302+
const layers = this.mapView.getLayers();
303+
if (index !== undefined && index < layers.count()) {
304+
layers.insert(index, native);
305+
} else {
306+
layers.add(native);
307+
}
308+
} catch (error) {
309+
console.error(error)
308310
}
309311
}
310312
}

src/ui-carto/ui/index.common.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,11 @@ export abstract class CartoViewBase extends ContentView {
165165
}
166166
}
167167

168+
disposeNativeView() {
169+
this.mapReady = false;
170+
super.disposeNativeView();
171+
}
172+
168173
[focusPosProperty.setNative](value: MapPos) {
169174
if (!this.nativeViewProtected || !this.nativeProjection) {
170175
return;

src/ui-carto/vectorelements/line.ios.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export class Line extends BaseLineVectorElement<NTLine, LineOptions> {
9999
if (styleBuilder instanceof NTLineStyle) {
100100
style = styleBuilder;
101101
} else if (styleBuilder instanceof LineStyleBuilder) {
102-
style = styleBuilder.buildStyle();
102+
style = (styleBuilder as LineStyleBuilder).buildStyle();
103103
} else if (styleBuilder.hasOwnProperty) {
104104
style = new LineStyleBuilder(styleBuilder).buildStyle();
105105
}

src/ui-carto/vectortiles/index.android.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ export class MBVectorTileDecoder extends BaseVectorTileDecoder<com.carto.vectort
3838
return new com.carto.vectortiles.MBVectorTileDecoder(new com.carto.styles.CartoCSSStyleSet(options.cartoCss));
3939
}
4040
} else if (pack) {
41-
console.log('new com.carto.styles.CompiledStyleSet', pack, options.style, options);
4241
const vectorTileStyleSet = new com.carto.styles.CompiledStyleSet(pack, options.style);
4342
const result = new com.carto.vectortiles.MBVectorTileDecoder(vectorTileStyleSet);
4443
return result;

0 commit comments

Comments
 (0)