fix(android): refreshVisibleItems fix to refresh all necessary views

Author: farfromrefug

packages/collectionview/platforms/android/java/com/nativescript/collectionview/Adapter.java

@@ -24,6 +24,14 @@ public CollectionViewCellHolder onCreateViewHolder(@NonNull ViewGroup parent, in
         return null;
     }
 
+    @NonNull
+    @Override
+    public void onViewRecycled(@NonNull CollectionViewCellHolder holder) {
+        if (this.adapterInterface != null) {
+            this.adapterInterface.onViewRecycled(holder);
+        }
+    }
+
     @Override
     public void onBindViewHolder(@NonNull CollectionViewCellHolder holder, int position) {
         if (this.adapterInterface != null) {
@@ -38,6 +46,7 @@ public int getItemCount() {
         }
         return 0;
     }
+
     @Override
     public int getItemViewType(int position) {
         if (this.adapterInterface != null) {

packages/collectionview/platforms/android/java/com/nativescript/collectionview/AdapterInterface.java

@@ -9,7 +9,10 @@ public interface AdapterInterface {
 
     void onBindViewHolder(@NonNull CollectionViewCellHolder holder, int position);
 
+    void onViewRecycled(@NonNull CollectionViewCellHolder holder);
+
     int getItemViewType(int position);
+
     long getItemId(int position);
 
     int getItemCount();

src/collectionview/collectionview.android.ts

@@ -790,12 +790,11 @@ export class CollectionView extends CollectionViewBase {
         if (!view) {
             return;
         }
-        const layoutManager = this.layoutManager as androidx.recyclerview.widget.LinearLayoutManager;
-        if (layoutManager['findFirstVisibleItemPosition']) {
-            const first = layoutManager.findFirstVisibleItemPosition();
-            const last = layoutManager.findLastVisibleItemPosition();
-            this._listViewAdapter.notifyItemRangeChanged(first, last - first + 1);
-        }
+        const ids = this._viewHolders
+            .map((s) => s['position'])
+            .filter((s) => s !== null)
+            .sort((a, b) => a - b);
+        this._listViewAdapter.notifyItemRangeChanged(ids[0], ids[ids.length - 1] - ids[0] + 1);
     }
     public isItemAtIndexVisible(index: number): boolean {
         const view = this.nativeViewProtected;
@@ -898,7 +897,8 @@ export class CollectionView extends CollectionViewBase {
             getItemViewType: this.getItemViewType.bind(this),
             getItemCount: this.getItemCount.bind(this),
             onCreateViewHolder: this.onCreateViewHolder.bind(this),
-            onBindViewHolder: this.onBindViewHolder.bind(this)
+            onBindViewHolder: this.onBindViewHolder.bind(this),
+            onViewRecycled: this.onViewRecycled.bind(this)
         });
         // const composedAdapter = new com.h6ah4i.android.widget.advrecyclerview.composedadapter.ComposedAdapter();
         // composedAdapter.addAdapter(new CollectionViewAdapter(new WeakRef(this)));
@@ -1023,6 +1023,7 @@ export class CollectionView extends CollectionViewBase {
         let view = holder.view;
         const bindingContext = this._prepareItem(view, position);
         const isNonSync = holder['defaultItemView'] === true;
+        holder['position'] = position;
 
         view = isNonSync ? (view as ContentView).content : view;
 
@@ -1070,6 +1071,10 @@ export class CollectionView extends CollectionViewBase {
             CLog(CLogTypes.log, 'onBindViewHolder done ', position);
         }
     }
+
+    onViewRecycled(holder) {
+        holder['position'] = null;
+    }
 }
 
 interface CollectionViewCellHolder extends com.nativescript.collectionview.CollectionViewCellHolder {

src/collectionview/typings/arv.d.ts

@@ -20,12 +20,14 @@ declare module com {
                 public getItemCount(): number;
                 public getItemId(param0: number): number;
                 public onBindViewHolder(param0: CollectionViewCellHolder, param1: number): void;
+                public onViewRecycled(param0: CollectionViewCellHolder): void;
                 constructor(implementation?: {
                     onCreateViewHolder(param0: globalAndroid.view.ViewGroup, param1: number): CollectionViewCellHolder;
                     getItemViewType(param0: number): number;
                     getItemCount(): number;
                     getItemId(param0: number): number;
                     onBindViewHolder(param0: CollectionViewCellHolder, param1: number): void;
+                    onViewRecycled(param0: CollectionViewCellHolder): void;
                 });
             }
             export class Adapter extends androidx.recyclerview.widget.RecyclerView.Adapter<CollectionViewCellHolder> {