fix: notify of disposing on disposeNativeView so that flavours can destroy their instances

Author: farfromrefuge

src/collectionview/index.android.ts

@@ -1174,6 +1174,7 @@ export class CollectionView extends CollectionViewBase {
         this.enumerateViewHolders((v) => {
             const view = v.view;
             if (view) {
+                this.notifyForItemAtIndex(CollectionViewBase.itemDisposingEvent, view, v.getAdapterPosition(), view.bindingContext, v);
                 if (view.isLoaded) {
                     view.callUnloaded();
                 }

src/collectionview/index.ios.ts

@@ -886,6 +886,7 @@ export class CollectionView extends CollectionViewBase {
 
     private _removeContainer(cell: CollectionViewCell): void {
         const view = cell.view;
+        this.notifyForItemAtIndex(CollectionViewBase.itemDisposingEvent, view, cell.currentIndex, view.bindingContext, cell);
         // This is to clear the StackLayout that is used to wrap ProxyViewContainer instances.
         if (!(view.parent instanceof CollectionView)) {
             this._removeView(view.parent);

src/collectionview/vue3/component.ts

@@ -96,50 +96,46 @@ export const CollectionView = defineComponent({
             if (event.view) {
                 event.view._batchUpdate(() => {
                     // todo: handle the case where the slot is not found
-                    render(vnode!, container);
+                    render(vnode, container);
                 });
             } else {
                 // todo: handle the case where the slot is not found
-                render(vnode!, container);
+                render(vnode, container);
             }
-            
 
             const cellEl = toRaw(vnode?.el?.nativeView);
             cellEl[LIST_CELL_ID] = id;
             cellEl[LIST_CELL_CONTAINER] = container;
             event.view = cellEl;
-
         }
 
         // render all realized templates as children
-        const cellVNODES = () =>
-            Object.entries(cells.value).map(([id, entry]) => {
-                const vnodes: VNode[] = ctx.slots[entry.slotName]?.(entry.itemCtx) ?? [
-                    // default template is just a label
-                    h('Label', {
-                        text: entry.itemCtx[props.alias]
-                    })
-                ];
-
-                if (vnodes.length > 1) {
-                    warn(`ListView template must contain a single root element. Found: ${vnodes.length}. Only the first one will be used.`);
-                }
-
-                const vnode: VNode = vnodes[0];
-                // set the key to the list cell id, so we can find this cell later...
-                vnode.key = id;
-
-                return vnode;
-            });
+        // const cellVNODES = () =>
+        //     Object.entries(cells.value).map(([id, entry]) => {
+        //         const vnodes: VNode[] = ctx.slots[entry.slotName]?.(entry.itemCtx) ?? [
+        //             // default template is just a label
+        //             h('Label', {
+        //                 text: entry.itemCtx[props.alias]
+        //             })
+        //         ];
+
+        //         if (vnodes.length > 1) {
+        //             warn(`ListView template must contain a single root element. Found: ${vnodes.length}. Only the first one will be used.`);
+        //         }
+
+        //         const vnode: VNode = vnodes[0];
+        //         // set the key to the list cell id, so we can find this cell later...
+        //         vnode.key = id;
+
+        //         return vnode;
+        //     });
 
         return () =>
-            h(
-                'NativeCollectionView',
-                {
-                    ref: collectionView,
-                    items: props.items,
-                    itemTemplates,
-                    onItemLoading
-                });
+            h('NativeCollectionView', {
+                ref: collectionView,
+                items: props.items,
+                itemTemplates,
+                onItemLoading
+            });
     }
 });