Skip to content

Commit a301f0f

Browse files
committed
fix: ios rollback breaking change
1 parent 6e980c1 commit a301f0f

File tree

1 file changed

+41
-41
lines changed

1 file changed

+41
-41
lines changed

src/collectionview.ios.ts

Lines changed: 41 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,11 @@ export class CollectionView extends CollectionViewBase {
249249
if (Trace.isEnabled()) {
250250
CLog(CLogTypes.info, 'deleteItemsAtIndexPaths', indexes.count);
251251
}
252-
dispatch_async(main_queue, () => {
253-
view.performBatchUpdatesCompletion(() => {
254-
view.deleteItemsAtIndexPaths(indexes);
255-
}, null);
256-
});
252+
// dispatch_async(main_queue, () => {
253+
view.performBatchUpdatesCompletion(() => {
254+
view.deleteItemsAtIndexPaths(indexes);
255+
}, null);
256+
// });
257257
return;
258258
}
259259
case ChangeType.Update: {
@@ -262,13 +262,13 @@ export class CollectionView extends CollectionViewBase {
262262
if (Trace.isEnabled()) {
263263
CLog(CLogTypes.info, 'reloadItemsAtIndexPaths',event.index, indexes.count);
264264
}
265-
dispatch_async(main_queue, () => {
266-
UIView.performWithoutAnimation(()=>{
267-
view.performBatchUpdatesCompletion(() => {
268-
view.reloadItemsAtIndexPaths(indexes);
269-
}, null);
270-
});
265+
// dispatch_async(main_queue, () => {
266+
UIView.performWithoutAnimation(()=>{
267+
view.performBatchUpdatesCompletion(() => {
268+
view.reloadItemsAtIndexPaths(indexes);
269+
}, null);
271270
});
271+
// });
272272

273273
return;
274274
}
@@ -280,39 +280,39 @@ export class CollectionView extends CollectionViewBase {
280280
if (Trace.isEnabled()) {
281281
CLog(CLogTypes.info, 'insertItemsAtIndexPaths', indexes.count);
282282
}
283-
dispatch_async(main_queue, () => {
284-
view.performBatchUpdatesCompletion(() => {
285-
view.insertItemsAtIndexPaths(indexes);
286-
}, null);
287-
});
283+
// dispatch_async(main_queue, () => {
284+
view.performBatchUpdatesCompletion(() => {
285+
view.insertItemsAtIndexPaths(indexes);
286+
}, null);
287+
// });
288288
// Reload the items to avoid duplicate Load on Demand indicators:
289289
return;
290290
}
291291
case ChangeType.Splice: {
292-
dispatch_async(main_queue, () => {
293-
view.performBatchUpdatesCompletion(() => {
294-
if (event.addedCount > 0) {
295-
const indexes = NSMutableArray.alloc<NSIndexPath>().init();
296-
for (let index = 0; index < event.addedCount; index++) {
297-
indexes.addObject(NSIndexPath.indexPathForItemInSection(event.index + index, 0));
298-
}
299-
view.insertItemsAtIndexPaths(indexes);
292+
// dispatch_async(main_queue, () => {
293+
view.performBatchUpdatesCompletion(() => {
294+
if (event.addedCount > 0) {
295+
const indexes = NSMutableArray.alloc<NSIndexPath>().init();
296+
for (let index = 0; index < event.addedCount; index++) {
297+
indexes.addObject(NSIndexPath.indexPathForItemInSection(event.index + index, 0));
300298
}
301-
if (event.removed && event.removed.length > 0) {
302-
const indexes = NSMutableArray.new<NSIndexPath>();
303-
for (let index = 0; index < event.removed.length; index++) {
304-
indexes.addObject(NSIndexPath.indexPathForItemInSection(event.index + index, 0));
305-
}
306-
this.unbindUnusedCells(event.removed);
307-
if (Trace.isEnabled()) {
308-
CLog(CLogTypes.info, 'deleteItemsAtIndexPaths', indexes.count);
309-
}
310-
view.performBatchUpdatesCompletion(() => {
311-
view.deleteItemsAtIndexPaths(indexes);
312-
}, null);
299+
view.insertItemsAtIndexPaths(indexes);
300+
}
301+
if (event.removed && event.removed.length > 0) {
302+
const indexes = NSMutableArray.new<NSIndexPath>();
303+
for (let index = 0; index < event.removed.length; index++) {
304+
indexes.addObject(NSIndexPath.indexPathForItemInSection(event.index + index, 0));
313305
}
314-
}, null);
315-
});
306+
this.unbindUnusedCells(event.removed);
307+
if (Trace.isEnabled()) {
308+
CLog(CLogTypes.info, 'deleteItemsAtIndexPaths', indexes.count);
309+
}
310+
view.performBatchUpdatesCompletion(() => {
311+
view.deleteItemsAtIndexPaths(indexes);
312+
}, null);
313+
}
314+
}, null);
315+
// });
316316
return;
317317
}
318318
}
@@ -362,9 +362,9 @@ export class CollectionView extends CollectionViewBase {
362362

363363
// TODO: this is ugly look here: https://github.com/nativescript-vue/nativescript-vue/issues/525
364364
// this.clearRealizedCells();
365-
dispatch_async(main_queue, () => {
366-
this.nativeViewProtected.reloadData();
367-
});
365+
// dispatch_async(main_queue, () => {
366+
this.nativeViewProtected.reloadData();
367+
// });
368368

369369
const args = {
370370
eventName: CollectionViewBase.dataPopulatedEvent,

0 commit comments

Comments
 (0)