feat: new contentInsetAdjustmentBehavior for iOS

Author: farfromrefug

src/collectionview-common.ts

@@ -27,6 +27,13 @@ import { CollectionView as CollectionViewDefinition, Orientation } from './colle
 
 export const CollectionViewTraceCategory = 'NativescriptCollectionView';
 
+// iOS only
+export enum ContentInsetAdjustmentBehavior {
+    Always,
+    Automatic,
+    Never,
+    ScrollableAxes
+}
 declare module '@nativescript/core/ui/core/view-base' {
     interface ViewBase {
         _recursiveSuspendNativeUpdates(type);
@@ -539,6 +546,6 @@ reverseLayoutProperty.register(CollectionViewBase);
 export const loadMoreThresholdProperty = new Property<CollectionViewBase, number>({
     name: 'loadMoreThreshold',
     defaultValue: 1,
-    valueConverter: parseInt
+    valueConverter: v => parseInt(v, 10)
 });
 loadMoreThresholdProperty.register(CollectionViewBase);

src/collectionview.android.ts

@@ -631,7 +631,6 @@ export class CollectionView extends CollectionViewBase {
     //     super.notifyDataSetChanged();
     // }
 
-    @profile
     public getItemViewType(position: number) {
         let resultType = 0;
         let selectorType: string = 'default';
@@ -653,7 +652,6 @@ export class CollectionView extends CollectionViewBase {
         return resultType;
     }
 
-    @profile
     disposeViewHolderViews() {
         this._viewHolders.forEach((v) => {
             v.view = null;
@@ -662,7 +660,6 @@ export class CollectionView extends CollectionViewBase {
         this._viewHolders = new Array();
         this._viewHolderChildren.forEach(this._removeViewCore);
     }
-    @profile
     getKeyByValue(viewType: number) {
         return this.templateStringTypeNumber.get(viewType);
     }

src/collectionview.ios.ts

@@ -6,6 +6,7 @@ import {
     KeyedTemplate,
     Length,
     Observable,
+    Property,
     ProxyViewContainer,
     Trace,
     View,
@@ -23,6 +24,37 @@ export * from './collectionview-common';
 
 const infinity = layout.makeMeasureSpec(0, layout.UNSPECIFIED);
 
+
+export enum ContentInsetAdjustmentBehavior {
+    Always = UIScrollViewContentInsetAdjustmentBehavior.Always,
+    Automatic = UIScrollViewContentInsetAdjustmentBehavior.Automatic,
+    Never = UIScrollViewContentInsetAdjustmentBehavior.Never,
+    ScrollableAxes = UIScrollViewContentInsetAdjustmentBehavior.ScrollableAxes
+}
+
+function parseContentInsetAdjustmentBehavior(value: string |  number) {
+    if (typeof value === 'string') {
+        switch(value) {
+            case 'always':
+                return ContentInsetAdjustmentBehavior.Always;
+            case 'never':
+                return ContentInsetAdjustmentBehavior.Never;
+            case 'ccrollableAxes':
+                return ContentInsetAdjustmentBehavior.ScrollableAxes;
+            default:
+            case 'automatic':
+                return ContentInsetAdjustmentBehavior.Automatic;
+        }
+    } else {
+        return value;
+    }
+}
+export const contentInsetAdjustmentBehaviorProperty = new Property<CollectionView, ContentInsetAdjustmentBehavior>({
+    name: 'contentInsetAdjustmentBehavior',
+    valueConverter: parseContentInsetAdjustmentBehavior,
+    defaultValue: ContentInsetAdjustmentBehavior.Automatic
+});
+
 export class CollectionView extends CollectionViewBase {
     private _layout: UICollectionViewLayout;
     private _dataSource: CollectionViewDataSource;
@@ -112,6 +144,10 @@ export class CollectionView extends CollectionViewBase {
         return this._map.size;
     }
 
+    public [contentInsetAdjustmentBehaviorProperty.setNative](value: ContentInsetAdjustmentBehavior) {
+        this.nativeViewProtected.contentInsetAdjustmentBehavior = value as any;
+    }
+
     public [paddingTopProperty.setNative](value: Length) {
         this._setPadding({ top: layout.toDeviceIndependentPixels(this.effectivePaddingTop) });
     }
@@ -505,12 +541,12 @@ export class CollectionView extends CollectionViewBase {
         }
         return undefined;
     }
-    layoutCell(index: number, cell: any, cellView: View): any {
+    layoutCell(index: number, cell: CollectionViewCell, cellView: View): any {
         const cellSize = this.getCellSize(index);
         cellView.iosOverflowSafeAreaEnabled = false;
         View.layoutChild(this, cellView, 0, 0, cellSize[0], cellSize[1]);
         if (Trace.isEnabled()) {
-            CLog(CLogTypes.log, 'layoutCell', index, cellSize[0], cellSize[1], cellView.getMeasuredWidth(), cellView.getMeasuredHeight());
+            CLog(CLogTypes.log, 'layoutCell', index, cellView.getMeasuredWidth(), cellView.getMeasuredHeight());
         }
     }
 
@@ -787,3 +823,5 @@ class UICollectionViewDelegateImpl extends NSObject implements UICollectionViewD
         }
     }
 }
+
+contentInsetAdjustmentBehaviorProperty.register(CollectionView);