Merge remote-tracking branch 'origin/master'

farfromrefug · farfromrefug · commit c4ffb604349d · 2024-10-09T10:59:04.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [5.3.43](https://github.com/@nativescript-community/ui-collectionview/compare/v5.3.42...v5.3.43) (2024-10-07)
+
+### Bug Fixes
+
+* **ios:** prevent error on observableArray item update ([0f75191](https://github.com/@nativescript-community/ui-collectionview/commit/0f751913c782c892f0e91a324c358c159294f87b))
+
+## [5.3.42](https://github.com/@nativescript-community/ui-collectionview/compare/v5.3.41...v5.3.42) (2024-10-04)
+
+### Bug Fixes
+
+* **ios:** prevent error while modifying ObservableArray while collectionview is in a non presented controller ([521d105](https://github.com/@nativescript-community/ui-collectionview/commit/521d1055b7d55df279ecd98fa4f6880453071054))
+
 ## [5.3.41](https://github.com/@nativescript-community/ui-collectionview/compare/v5.3.40...v5.3.41) (2024-09-30)
 
 ### Bug Fixes
diff --git a/docs/assets/navigation.js b/docs/assets/navigation.js
diff --git a/docs/assets/search.js b/docs/assets/search.js
diff --git a/lerna.json b/lerna.json
@@ -1,5 +1,5 @@
 {
-    "version": "5.3.41",
+    "version": "5.3.43",
     "$schema": "node_modules/@lerna-lite/cli/schemas/lerna-schema.json",
     "packages": [
         "packages/*"
diff --git a/packages/collectionview/CHANGELOG.md b/packages/collectionview/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [5.3.43](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.42...v5.3.43) (2024-10-07)
+
+**Note:** Version bump only for package @nativescript-community/ui-collectionview
+
+## [5.3.42](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.41...v5.3.42) (2024-10-04)
+
+**Note:** Version bump only for package @nativescript-community/ui-collectionview
+
 ## [5.3.41](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.40...v5.3.41) (2024-09-30)
 
 **Note:** Version bump only for package @nativescript-community/ui-collectionview
diff --git a/packages/collectionview/package.json b/packages/collectionview/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@nativescript-community/ui-collectionview",
-    "version": "5.3.41",
+    "version": "5.3.43",
     "description": "Allows you to easily add a collection view (grid list view) to your projects. Supports vertical and horizontal modes, templating, and more.",
     "main": "./index",
     "sideEffects": false,
diff --git a/packages/swipemenu/CHANGELOG.md b/packages/swipemenu/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [5.3.43](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.42...v5.3.43) (2024-10-07)
+
+**Note:** Version bump only for package @nativescript-community/ui-collectionview-swipemenu
+
+## [5.3.42](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.41...v5.3.42) (2024-10-04)
+
+**Note:** Version bump only for package @nativescript-community/ui-collectionview-swipemenu
+
 ## [5.3.41](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.40...v5.3.41) (2024-09-30)
 
 **Note:** Version bump only for package @nativescript-community/ui-collectionview-swipemenu
diff --git a/packages/swipemenu/package.json b/packages/swipemenu/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@nativescript-community/ui-collectionview-swipemenu",
-    "version": "5.3.41",
+    "version": "5.3.43",
     "description": "A NativeScript CollectionView SwipeMenu Plugin.",
     "main": "./index",
     "funding": "https://github.com/sponsors/farfromrefug",
@@ -41,7 +41,7 @@
     "homepage": "https://github.com/nativescript-community/ui-collectionview#readme",
     "dependencies": {
         "@nativescript-community/class-mixins": "^1.0.0",
-        "@nativescript-community/ui-collectionview": "^5.3.41",
+        "@nativescript-community/ui-collectionview": "^5.3.43",
         "@nativescript-community/ui-drawer": "^0.1.27"
     }
 }
diff --git a/packages/waterfall/CHANGELOG.md b/packages/waterfall/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [5.3.43](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.42...v5.3.43) (2024-10-07)
+
+**Note:** Version bump only for package @nativescript-community/ui-collectionview-waterfall
+
+## [5.3.42](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.41...v5.3.42) (2024-10-04)
+
+**Note:** Version bump only for package @nativescript-community/ui-collectionview-waterfall
+
 ## [5.3.41](https://github.com/nativescript-community/ui-collectionview/compare/v5.3.40...v5.3.41) (2024-09-30)
 
 **Note:** Version bump only for package @nativescript-community/ui-collectionview-waterfall
diff --git a/packages/waterfall/package.json b/packages/waterfall/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@nativescript-community/ui-collectionview-waterfall",
-    "version": "5.3.41",
+    "version": "5.3.43",
     "description": "A NativeScript CollectionView waterfall Plugin.",
     "main": "./index",
     "funding": "https://github.com/sponsors/farfromrefug",
@@ -39,6 +39,6 @@
     },
     "homepage": "https://github.com/nativescript-community/ui-collectionview#readme",
     "dependencies": {
-        "@nativescript-community/ui-collectionview": "^5.3.41"
+        "@nativescript-community/ui-collectionview": "^5.3.43"
     }
 }
diff --git a/src/collectionview/index.ios.ts b/src/collectionview/index.ios.ts
@@ -504,7 +504,7 @@ export class CollectionView extends CollectionViewBase {
             if (viewIsLoaded) {
                 view.performBatchUpdatesCompletion(c, null);
             } else {
-                c();
+                this.refresh();
             }
         };
 
@@ -530,7 +530,7 @@ export class CollectionView extends CollectionViewBase {
             case ChangeType.Update: {
                 const indexes = NSMutableArray.new<NSIndexPath>();
                 indexes.addObject(NSIndexPath.indexPathForRowInSection(event.index, 0));
-                if (sizes) {
+                if (sizes && event.index < sizes.count - 1) {
                     sizes.replaceObjectAtIndexWithObject(event.index, NSValue.valueWithCGSize(CGSizeZero));
                 }
                 // this._sizes[event.index] = null;

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "version": "5.3.41",`
	`2`	`+ "version": "5.3.43",`
`3`	`3`	`"$schema": "node_modules/@lerna-lite/cli/schemas/lerna-schema.json",`
`4`	`4`	`"packages": [`
`5`	`5`	`"packages/*"`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@nativescript-community/ui-collectionview",`
`3`		`- "version": "5.3.41",`
	`3`	`+ "version": "5.3.43",`
`4`	`4`	`"description": "Allows you to easily add a collection view (grid list view) to your projects. Supports vertical and horizontal modes, templating, and more.",`
`5`	`5`	`"main": "./index",`
`6`	`6`	`"sideEffects": false,`