fix(android): allow to configure memory size

Author: farfromrefug

packages/image/platforms/android/java/com/nativescript/image/CustomGlideModule.java

@@ -32,13 +32,29 @@ public class CustomGlideModule extends AppGlideModule {
   @Override
   public void applyOptions(@NonNull Context context, @NonNull GlideBuilder builder) {
 
+    // Get configuration
+    GlideConfiguration config = GlideConfiguration.getInstance();
+    
+    // Determine memory cache size
+    long memoryCacheSize;
+    if (config.getMemoryCacheSize() > 0) {
+      // Use custom size
+      memoryCacheSize = config.getMemoryCacheSize();
+      // Log.i(TAG, "Using custom memory cache size: " + memoryCacheSize + " bytes");
+    } else {
+      // Use default calculator
+      MemorySizeCalculator calculator = new MemorySizeCalculator.Builder(context)
+          .setMemoryCacheScreens(config.getMemoryCacheScreens())
+          .build();
+      memoryCacheSize = calculator.getMemoryCacheSize();
+      // Log.i(TAG, "Using calculated memory cache size: " + memoryCacheSize + " bytes with memoryCacheSceens: " + config.getMemoryCacheScreens());
+    }
+    
     // Use our custom memory cache wrapper
-    MemorySizeCalculator calculator = new MemorySizeCalculator.Builder(context)
-        .setMemoryCacheScreens(2)
-        .build();
-    LruResourceCache memoryCache = new LruResourceCache(calculator.getMemoryCacheSize());
+    LruResourceCache memoryCache = new LruResourceCache(memoryCacheSize);
     EvictionManager.get().setMemoryCache(memoryCache);
     builder.setMemoryCache(memoryCache);
+    
     // Set a disk cache factory that also registers the disk cache instance with
     // EvictionManager.
     builder.setDiskCache(new DiskCache.Factory() {

packages/image/platforms/android/java/com/nativescript/image/GlideConfiguration.java

@@ -0,0 +1,48 @@
+package com.nativescript.image;
+
+/**
+ * Singleton to hold Glide configuration values that must be set before Glide initializes.
+ * Call GlideConfiguration.setMemoryCacheSize() from your Application.onCreate() 
+ * or before any Glide usage.
+ */
+public class GlideConfiguration {
+    private static GlideConfiguration instance;
+    
+    private long memoryCacheSize = -1; // -1 means use default
+    private float memoryCacheScreens = 2.0f;
+    
+    private GlideConfiguration() {
+    }
+    
+    public static synchronized GlideConfiguration getInstance() {
+        if (instance == null) {
+            instance = new GlideConfiguration();
+        }
+        return instance;
+    }
+    
+    /**
+     * Set custom memory cache size in bytes.
+     * Must be called before Glide is initialized (before first image load).
+     * @param bytes Size in bytes, or -1 to use default calculator
+     */
+    public void setMemoryCacheSize(long bytes) {
+        this.memoryCacheSize = bytes;
+    }
+    
+    public long getMemoryCacheSize() {
+        return memoryCacheSize;
+    }
+    
+    /**
+     * Set memory cache screens multiplier (default 2.0).
+     * Only used if memoryCacheSize is -1.
+     */
+    public void setMemoryCacheScreens(float screens) {
+        this.memoryCacheScreens = screens;
+    }
+    
+    public float getMemoryCacheScreens() {
+        return memoryCacheScreens;
+    }
+}

packages/image/platforms/android/native-api-usage.json

@@ -14,6 +14,7 @@
         "com.nativescript.image:CompositeRequestListener",
         "com.nativescript.image:MatrixDrawableImageViewTarget",
         "com.nativescript.image:MatrixImageView",
+        "com.nativescript.image:GlideConfiguration",
         "com.bumptech.glide:Glide",
         "com.bumptech.glide.signature:ObjectKey",
         "com.bumptech.glide.request:RequestOptions",

src/image/index-common.ts

@@ -131,9 +131,13 @@ export function wrapNativeException(ex, errorType = typeof ex) {
 }
 
 export interface ImagePipelineConfigSetting {
+    // android only, disk cache key store persists to use evictFromDiskCache between app launches
     usePersistentCacheKeyStore?: boolean;
     // android signature key for cache. You can bump/change (v1, v2,...) to invalidate all cache
     globalSignatureKey?: string;
+
+    memoryCacheSize?: number; // in bytes
+    memoryCacheScreens?: number; // multiplier for auto-calculation
 }
 
 export type Stretch = 'none' | 'fill' | 'aspectFill' | 'aspectFit';

src/image/index.android.ts

@@ -1,7 +1,6 @@
 export * from './index-common';
 import { Background, Color, ImageAsset, ImageSource, Trace, Utils, backgroundInternalProperty, knownFolders, path } from '@nativescript/core';
 import { isString } from '@nativescript/core/utils/types';
-import { layout } from '@nativescript/core/utils/layout-helper';
 import {
     AnimatedImage,
     CLog,
@@ -50,27 +49,25 @@ const globalSignatureKey = 'v1';
 export function initialize(config?: ImagePipelineConfigSetting): void {
     if (!initialized) {
         const context = Utils.android.getApplicationContext();
-        if (!context) {
-            return;
+        const glideConfig = com.nativescript.image.GlideConfiguration.getInstance();
+        if (config?.memoryCacheSize > 0) {
+            glideConfig.setMemoryCacheSize(config.memoryCacheSize);
         }
-        if (config?.usePersistentCacheKeyStore) {
-            const sharedStore = new com.nativescript.image.SharedPrefCacheKeyStore(context.getApplicationContext());
-            com.nativescript.image.EvictionManager.get().setPersistentStore(sharedStore);
+
+        if (config?.memoryCacheScreens > 0) {
+            glideConfig.setMemoryCacheScreens(config.memoryCacheScreens);
         }
-        // bumping `v1` will invalidate all cache
-        signature = new com.bumptech.glide.signature.ObjectKey(config?.globalSignatureKey ?? globalSignatureKey);
 
-        initialized = true;
+        signature = new com.bumptech.glide.signature.ObjectKey(config?.globalSignatureKey || globalSignatureKey);
+
+        // Now initialize Glide (which will read from GlideConfiguration)
         glideInstance = com.bumptech.glide.Glide.get(context);
-        com.nativescript.image.EvictionManager.get().clearAll();
 
         // this is needed for further buildKey to trigger ...
-        com.bumptech.glide.Glide.with(context)
-            .load('toto')
-            .apply(new com.bumptech.glide.request.RequestOptions().signature(signature))
-            .preload();
+        com.bumptech.glide.Glide.with(context).load('toto').apply(new com.bumptech.glide.request.RequestOptions().signature(signature)).preload();
         // com.nativescript.image.EngineKeyFactoryMethodDumper.dumpKeyFactoryMethods(glideInstance);
         // com.nativescript.image.ForcePreloadTest.forcePreloadAfterInjection(context, 'https://example.com/test-image.png');
+        initialized = true;
     }
 }
 
@@ -235,10 +232,7 @@ export class ImagePipeline {
             try {
                 const context = Utils.android.getApplicationContext();
                 const requestManager = com.bumptech.glide.Glide.with(context);
-                const requestBuilder = requestManager
-                    .asBitmap()
-                    .load(uri)
-                    .apply(new com.bumptech.glide.request.RequestOptions().signature(signature));
+                const requestBuilder = requestManager.asBitmap().load(uri).apply(new com.bumptech.glide.request.RequestOptions().signature(signature));
 
                 let futureTarget = null;
                 function clearLater() {
@@ -822,10 +816,7 @@ export class Img extends ImageBase {
             target.setClearFirst(false);
         }
 
-        requestBuilder
-            .apply(ro)
-            .listener(new com.nativescript.image.CompositeRequestListener(objectArr))
-            .into(target);
+        requestBuilder.apply(ro).listener(new com.nativescript.image.CompositeRequestListener(objectArr)).into(target);
     }
 
     private notifyLoadSource(source: string) {

src/image/index.d.ts

@@ -1,6 +1,7 @@
 import { ImageAsset, ImageSource, View } from '@nativescript/core';
+import { ImagePipelineConfigSetting } from './index-common';
 
-export * from './index-common.ts';
+export * from './index-common';
 
 /**
  * When called, initializes the android Image library. Calling this method is required.
@@ -375,15 +376,6 @@ export enum ScaleType {
     focusCrop
 }
 
-/**
- * Advanced Configurations used for initializing Image
- */
-export interface ImagePipelineConfigSetting {
-    // android only, disk cache key store persists to use evictFromDiskCache between app launches
-    usePersistentCacheKeyStore?: boolean;
-    // android signature key for cache. You can bump/change (v1, v2,...) to invalidate all cache
-    globalSignatureKey?: string;
-}
 export const ImageViewTraceCategory;
 
 export type GetContextFromOptionsCallback = (context: NSDictionary<string, any>, transformers: any[], options: Partial<Img>) => void;

src/image/typings/ui_image.android.d.ts

@@ -45,6 +45,12 @@ declare namespace com {
 	}
 	export namespace nativescript {
 		export namespace image {
+			export class GlideConfiguration {
+                setMemoryCacheScreens(memoryCacheScreens: number);
+                getMemoryCacheSize(): number;
+                setMemoryCacheSize(memoryCacheSize: number);
+				static getInstance():GlideConfiguration;
+			}
 			export class CacheKeyStore {
 				public static class: java.lang.Class<com.nativescript.image.CacheKeyStore>;
 				public put(id: string, keys: com.nativescript.image.CacheKeyStore.StoredKeys): void;