fix(image): better error handling

Author: farfromrefug

src/image/index-common.ts

@@ -103,6 +103,30 @@ export interface ImageError {
     toString(): string;
 }
 
+export function wrapNativeException(ex, errorType = typeof ex) {
+    if (typeof ex === 'string') {
+        return new Error(ex);
+    }
+    if (!(ex instanceof Error)) {
+        if (__ANDROID__) {
+            const err = new Error(ex.toString());
+            err['nativeException'] = ex;
+            //@ts-ignore
+            err['stackTrace'] = com.tns.NativeScriptException.getStackTraceAsString(ex);
+            return err;
+        }
+        if (__IOS__) {
+            const err = new Error(ex.localizedDescription);
+            err['nativeException'] = ex;
+            err['code'] = ex.code;
+            err['domain'] = ex.domain;
+            // TODO: we loose native stack. see how to get it
+            return err;
+        }
+    }
+    return ex;
+}
+
 export interface ImagePipelineConfigSetting {
     isDownsampleEnabled?: boolean;
     leakTracker?: any;

src/image/index.android.ts

@@ -32,8 +32,10 @@ import {
     showProgressBarProperty,
     srcProperty,
     stretchProperty,
-    tintColorProperty
+    tintColorProperty,
+    wrapNativeException
 } from './index-common';
+import { FailureEventData } from '@nativescript-community/ui-image';
 
 let initialized = false;
 let initializeConfig: ImagePipelineConfigSetting;
@@ -340,18 +342,6 @@ export class IntermediateEventData extends EventData {
     }
 }
 
-export class FailureEventData extends EventData {
-    private _error: ImageError;
-
-    get error(): ImageError {
-        return this._error;
-    }
-
-    set error(value: ImageError) {
-        this._error = value;
-    }
-}
-
 export const needUpdateHierarchy = function (targetOrNeedsLayout: any, propertyKey?: string | Symbol, descriptor?: PropertyDescriptor): any {
     if (typeof targetOrNeedsLayout === 'boolean') {
         return function (target2: any, propertyKey: string | Symbol, descriptor: PropertyDescriptor) {
@@ -668,7 +658,7 @@ export class Img extends ImageBase {
                                     const imageError = new ImageError(throwable);
                                     nativeView.notify({
                                         eventName,
-                                        error: imageError
+                                        error: wrapNativeException(throwable)
                                     } as FailureEventData);
                                 }
                             }
@@ -681,10 +671,9 @@ export class Img extends ImageBase {
                             if (nativeView) {
                                 const eventName = ImageBase.intermediateImageFailedEvent;
                                 if (nativeView.hasListeners(eventName)) {
-                                    const imageError = new ImageError(throwable);
                                     nativeView.notify({
                                         eventName,
-                                        error: imageError
+                                        error: wrapNativeException(throwable)
                                     } as FailureEventData);
                                 }
                             }

src/image/index.d.ts

@@ -314,21 +314,11 @@ export class IntermediateEventData {
 /**
  * Instances of this class are provided to the handlers of the {@link failure} and {@link intermediateImageFailed}.
  */
-export class FailureEventData {
-    /**
-     * Returns the name of the event that has been fired.
-     */
-    eventName: string;
-
-    /**
-     * The object that fires the event.
-     */
-    object: any;
-
+export class FailureEventData extends EventData {
     /**
      * An object containing information about the status of the event.
      */
-    error: ImageError;
+    error: Error;
 }
 
 /**

src/image/index.ios.ts

@@ -16,8 +16,10 @@ import {
     imageRotationProperty,
     placeholderImageUriProperty,
     srcProperty,
-    stretchProperty
+    stretchProperty,
+    wrapNativeException
 } from './index-common';
+import { FailureEventData } from '@nativescript-community/ui-image';
 
 export class ImageInfo implements ImageInfoBase {
     constructor(
@@ -402,8 +404,8 @@ export class Img extends ImageBase {
         if (error) {
             this.notify({
                 eventName: Img.failureEvent,
-                error
-            });
+                error: wrapNativeException(error)
+            } as FailureEventData);
             if (this.failureImageUri) {
                 image = this.getUIImage(this.failureImageUri);
                 this._setNativeImage(image, animate);