fix: title/subtitle are now optional. If not defined there wont be a callout

Author: farfromrefug

src/ui-mapbox/index.ios.ts

@@ -707,7 +707,9 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
                 if (this.selectedMarker && !this.isMarkerSelected(marker)) {
                     this.deselectMarker(this.selectedMarker);
                 }
-                await this.showCalloutForMarkerById(marker.id + '');
+                if (marker.title || marker.subtitle) {
+                    await this.showCalloutForMarkerById(marker.id + '');
+                }
                 resolve();
             } catch (ex) {
                 if (Trace.isEnabled()) {
@@ -1435,7 +1437,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
 
     toggleCalloutForMarkerById(markerId: string): void {
         const m = this._markers.find((x) => `${x.id}` === markerId);
-        if (!m || !m.id) return;
+        if (!m || !m.id || (!m.title && !m.subtitle)) return;
         const exists = this.bridgeInstance.hasViewAnnotationForMarker(markerId);
         if (exists) this.hideCalloutForMarkerById(markerId);
         else this.showCalloutForMarkerById(markerId);

src/ui-mapbox/markers/Marker.android.ts

@@ -18,9 +18,6 @@ export class AndroidMarker {
     layerId: string;
 
     constructor(opts: { id: string | number; position: com.mapbox.geojson.Point; icon: android.graphics.Bitmap; title?: string; snippet?: string }) {
-        if (!opts.title && !opts.snippet) {
-            throw new Error('Marker should have either title or snippet!');
-        }
 
         this.position = opts.position;
         this.id = opts.id;

src/ui-mapbox/markers/MarkerManager.android.ts

@@ -228,13 +228,14 @@ export class MarkerManager {
             this.deselectMarker(this.selectedMarker);
         }
         this.selectedMarker = marker;
-
-        this.prepareViewAnnotation(marker, (e) => {
-            // info Window tapped.
-            if (!this.onInfoWindowTapped(marker)) {
-                this.deselectMarker(marker);
-            }
-        });
+        if (marker.title || marker.snippet) {
+            this.prepareViewAnnotation(marker, (e) => {
+                // info Window tapped.
+                if (!this.onInfoWindowTapped(marker)) {
+                    this.deselectMarker(marker);
+                }
+            });
+        }
     }
 
     deselectMarker(marker: AndroidMarker) {