fix(ios): removed many unwanted error message (no actual error)

Author: farfromrefug

packages/ui-mapbox/platforms/ios/src/MapboxBridge.swift

@@ -592,7 +592,7 @@ public class MapboxBridge: NSObject {
         guard let mv = mapView else { completion(false, NSError(domain: "MapboxBridge", code: 1, userInfo: [NSLocalizedDescriptionKey: "No map available"])); return }
         mv.mapboxMap.onStyleLoaded.observeNext { _ in completion(true, nil) }.store(in: &cancelables)
         mv.mapboxMap.loadStyle(getMapStyleURI(styleURIorURL));
-        completion(false, NSError(domain: "MapboxBridge", code: 2, userInfo: [NSLocalizedDescriptionKey: "Invalid style string"]))
+        // completion(false, NSError(domain: "MapboxBridge", code: 2, userInfo: [NSLocalizedDescriptionKey: "Invalid style string"]))
     }
 
     // MARK: - Camera / viewport / animateCamera
@@ -953,14 +953,14 @@ public class MapboxBridge: NSObject {
         return true
 
     }
-    @objc public func removePolygons(_ _ids: [String]?) {
-        guard let manager = polygonAnnotationManager else { return }
+    @objc public func removePolygons(_ _ids: [String]?) -> Bool {
+        guard let manager = polygonAnnotationManager else { return false }
         guard let ids = _ids else {
             manager.annotations.removeAll()
             if let outlineManager = polygonOutlineAnnotationManager {
                 outlineManager.annotations.removeAll()
             }
-            return
+            return true
         }
         //        guard let data = idsJSON!.data(using: .utf8) else { return }
         //        guard let ids = try? JSONSerialization.jsonObject(with: data, options: []) as! [String] else { return }
@@ -977,18 +977,20 @@ public class MapboxBridge: NSObject {
         if let outlineManager = polygonOutlineAnnotationManager {
             outlineManager.annotations.removeAll { idSet.contains($0.id) }
         }
+        return true
     }
 
-    @objc public func removePolylines(_ _ids: [String]?) {
-        guard let manager = polylineAnnotationManager else { return }
+    @objc public func removePolylines(_ _ids: [String]?) -> Bool {
+        guard let manager = polylineAnnotationManager else { return false }
         guard let ids = _ids else {
             manager.annotations.removeAll()
-            return
+            return true
         }
 
         let idSet = Set<String>(ids)
 
         manager.annotations.removeAll { idSet.contains($0.id) }
+        return true
     }
 
     enum GeoJSONSourceUpdateError: Error {

src/ui-mapbox/index.ios.ts

@@ -182,7 +182,8 @@ export class MapboxView extends MapboxViewBase {
 
     async disposeNativeView(): Promise<void> {
         this.nativeView.owner = null;
-        if (this.mapbox) await this.mapbox.destroy();
+        this.mapbox?.destroy();
+        this.mapbox = null;
         super.disposeNativeView();
     }
 
@@ -468,7 +469,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
                 nativeMap.autoresizingMask = UIViewAutoresizing.FlexibleWidth | UIViewAutoresizing.FlexibleHeight;
 
                 _markers = [];
-                this.addMarkers(settings.markers);
+                this.addMarkers(settings.markers || []);
                 // setTimeout(() => view.addSubview(nativeMap), 0);
                 view.addSubview(nativeMap);
                 this.setMapboxViewInstance(nativeMap);
@@ -532,22 +533,23 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
                     this._programmaticMapView = null;
                 }
                 const bridge = MapboxBridge.bridgeFor(theMap);
-                bridge.destroy();
-                if (bridge === this.bridgeInstance) {
-                    this.bridgeInstance = null;
+                if (Trace.isEnabled()) {
+                    CLog(CLogTypes.info, 'destroy():', theMap, bridge);
                 }
-                try {
-                    this._observerTokens.forEach((t) => {
-                        try {
-                            NSNotificationCenter.defaultCenter.removeObserver(t);
-                        } catch (e) {
-                            console.error(e, e.stack);
-                        }
-                    });
-                    this._observerTokens = [];
-                } catch (e) {
-                    console.error(e, e.stack);
+                if (bridge) {
+                    bridge.destroy();
+                    if (bridge === this.bridgeInstance) {
+                        this.bridgeInstance = null;
+                    }
                 }
+                this._observerTokens.forEach((t) => {
+                    try {
+                        NSNotificationCenter.defaultCenter.removeObserver(t);
+                    } catch (e) {
+                        console.error(e, e.stack);
+                    }
+                });
+                this._observerTokens = [];
 
                 if (this._reusableCalloutView) {
                     this._reusableCalloutView._tearDownUI();
@@ -1101,12 +1103,19 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
                     reject('No bridge available');
                     return;
                 }
+                if (Trace.isEnabled()) {
+                    CLog(CLogTypes.info, 'setMapStyle():', style);
+                }
                 const styleStr = (typeof style === 'string' ? style : (style as any).toString()) ?? 'streets';
                 b.setStyle(styleStr, (success: boolean, error?: any) => {
+                    if (Trace.isEnabled()) {
+                        CLog(CLogTypes.info, 'setMapStyle():', style, 'done:', success, error);
+                    }
                     if (success) resolve();
                     else reject(error && error.localizedDescription ? error.localizedDescription : error || 'Error setting style');
                 });
             } catch (ex) {
+                console.error('setMapStyle():', ex, ex['stack']);
                 reject(ex);
             }
         });