fix: rename maxLength to counterMaxLength

this allows to use both counterMaxLength and N maxLength

Author: farfromrefug

src/core/textbase/cssproperties.ts

@@ -24,12 +24,12 @@ export const errorProperty = new CssProperty<Style, string>({
     cssName: 'error'
 });
 errorProperty.register(Style);
-export const maxLengthProperty = new CssProperty<Style, number>({
-    name: 'maxLength',
-    cssName: 'max-length',
+export const counterMaxLengthProperty = new CssProperty<Style, number>({
+    name: 'counterMaxLength',
+    cssName: 'counter-max-length',
     valueConverter: v => parseFloat(v)
 });
-maxLengthProperty.register(Style);
+counterMaxLengthProperty.register(Style);
 export const floatingProperty = new CssProperty<Style, boolean>({
     name: 'floating',
     cssName: 'floating',

src/textfield/textfield.android.ts

@@ -1,5 +1,6 @@
 import { getLayout, stateSets } from '@nativescript-community/ui-material-core/android/utils';
 import {
+    counterMaxLengthProperty,
     digitsProperty,
     errorColorProperty,
     errorProperty,
@@ -8,7 +9,6 @@ import {
     floatingProperty,
     helperColorProperty,
     helperProperty,
-    maxLengthProperty,
     strokeColorProperty,
     strokeDisabledColorProperty,
     strokeInactiveColorProperty
@@ -180,7 +180,7 @@ export class TextField extends TextFieldBase {
         this.layoutView.setErrorEnabled(!!value);
     }
 
-    [maxLengthProperty.setNative](value: number) {
+    [counterMaxLengthProperty.setNative](value: number) {
         this.layoutView.setCounterEnabled(value > 0);
         this.layoutView.setCounterMaxLength(value);
     }

src/textfield/textfield.common.ts

@@ -12,7 +12,7 @@ export abstract class TextFieldBase extends NTextField {
 
     @cssProperty helper: string;
     @cssProperty helperColor: Color;
-    @cssProperty maxLength: number;
+    @cssProperty counterMaxLength: number;
     @cssProperty errorColor: Color;
     @cssProperty floating: boolean;
     @cssProperty placeholderColor: Color;

src/textfield/textfield.d.ts

@@ -13,7 +13,7 @@ export class TextField extends NTextField {
 
     helper: string;
     helperColor: Color;
-    maxLength: number;
+    counterMaxLength: number;
     errorColor: Color;
     floating: boolean;
     placeholderColor: Color;

src/textfield/textfield.ios.ts

@@ -1,6 +1,7 @@
 import { themer } from '@nativescript-community/ui-material-core';
 import {
     buttonColorProperty,
+    counterMaxLengthProperty,
     digitsProperty,
     errorColorProperty,
     errorProperty,
@@ -9,7 +10,6 @@ import {
     floatingProperty,
     helperColorProperty,
     helperProperty,
-    maxLengthProperty,
     strokeColorProperty,
     strokeDisabledColorProperty,
     strokeInactiveColorProperty,
@@ -151,7 +151,7 @@ export class TextField extends TextFieldBase {
         if (range.length > 0) {
             const delta = replacementString.length - range.length;
             if (delta > 0) {
-                if (textField.text.length + delta > this.maxLength) {
+                if (textField.text.length + delta > this.counterMaxLength) {
                     return false;
                 }
             }
@@ -321,7 +321,7 @@ export class TextField extends TextFieldBase {
         const color: UIColor = temp.ios;
         this._controller.leadingUnderlineLabelTextColor = color;
     }
-    [maxLengthProperty.setNative](value: number) {
+    [counterMaxLengthProperty.setNative](value: number) {
         this._controller.characterCountMax = value;
     }
     [floatingProperty.setNative](value: boolean) {

src/textview/textview.android.ts

@@ -1,12 +1,12 @@
 import {
+    counterMaxLengthProperty,
     errorColorProperty,
     errorProperty,
     floatingColorProperty,
     floatingInactiveColorProperty,
     floatingProperty,
     helperColorProperty,
     helperProperty,
-    maxLengthProperty,
     strokeColorProperty,
     strokeInactiveColorProperty,
 } from '@nativescript-community/ui-material-core/textbase/cssproperties';
@@ -187,7 +187,7 @@ export class TextView extends TextViewBase {
         this.layoutView.setErrorEnabled(!!value);
     }
 
-    [maxLengthProperty.setNative](value: number) {
+    [counterMaxLengthProperty.setNative](value: number) {
         this.layoutView.setCounterEnabled(value > 0);
         this.layoutView.setCounterMaxLength(value);
     }

src/textview/textview.common.ts

@@ -8,7 +8,7 @@ export abstract class TextViewBase extends NSTextView {
 
     @cssProperty helper: string;
     @cssProperty helperColor: Color;
-    @cssProperty maxLength: number;
+    @cssProperty counterMaxLength: number;
     @cssProperty errorColor: Color;
     @cssProperty floating: boolean;
     @cssProperty placeholderColor: Color;

src/textview/textview.d.ts

@@ -13,7 +13,7 @@ export class TextView extends EditableTextBase {
 
     helper: string;
     helperColor: Color;
-    maxLength: number;
+    counterMaxLength: number;
     errorColor: Color;
     floating: boolean;
     placeholderColor: Color;

src/textview/textview.ios.ts

@@ -1,14 +1,14 @@
 import { themer } from '@nativescript-community/ui-material-core';
 import {
     buttonColorProperty,
+    counterMaxLengthProperty,
     errorColorProperty,
     errorProperty,
     floatingColorProperty,
     floatingInactiveColorProperty,
     floatingProperty,
     helperColorProperty,
     helperProperty,
-    maxLengthProperty,
     strokeColorProperty,
     strokeInactiveColorProperty,
 } from '@nativescript-community/ui-material-core/textbase/cssproperties';
@@ -318,7 +318,7 @@ export class TextView extends TextViewBase {
         const color: UIColor = temp.ios;
         this._controller.leadingUnderlineLabelTextColor = color;
     }
-    [maxLengthProperty.setNative](value: number) {
+    [counterMaxLengthProperty.setNative](value: number) {
         this._controller.characterCountMax = value;
     }
     [floatingProperty.setNative](value: boolean) {