fix: notify of disposing on disposeNativeView so that flavours can destroy their instances

Author: farfromrefuge

src/ui-pager/index.android.ts

@@ -268,6 +268,12 @@ export class Pager extends PagerBase {
     disposeViewHolderViews() {
         this.enumerateViewHolders((v) => {
             const view = v.view;
+            this.notify({
+                eventName: Pager.itemDisposingEvent,
+                index: v.getAdapterPosition(),
+                android: v,
+                view
+            } as ItemEventData);
             // if (view && view.isLoaded) {
             //     view.callUnloaded();
             // }

src/ui-pager/index.ios.ts

@@ -505,11 +505,10 @@ export class Pager extends PagerBase {
     }
 
     private clearRealizedCells() {
-        const that = new WeakRef<Pager>(this);
-        this.mMap.forEach(function (value, key: PagerCell) {
-            that.get()._removeContainer(key);
-            that.get()._clearCellViews(key);
-        }, that);
+        this.mMap.forEach((value, key: PagerCell) => {
+            this._removeContainer(key);
+            this._clearCellViews(key);
+        });
         this.mMap.clear();
     }
     private _clearCellViews(cell: PagerCell) {
@@ -560,18 +559,14 @@ export class Pager extends PagerBase {
     }
 
     public _removeContainer(cell: PagerCell, index?: number): void {
-        let view = cell.view;
+        const view = cell.view;
 
-        const args = {
+        this.notify({
             eventName: Pager.itemDisposingEvent,
-            object: this,
             index,
-            android: undefined,
             ios: cell,
             view
-        } as ItemEventData;
-        this.notify(args);
-        view = args.view;
+        } as ItemEventData);
         if (view && view.parent) {
             // This is to clear the StackLayout that is used to wrap ProxyViewContainer instances.
             if (!(view.parent instanceof Pager)) {

src/ui-pager/svelte/index.ts

@@ -54,6 +54,7 @@ export default class PagerViewElement extends NativeViewElementNode<Pager> {
         const nativeView = this.nativeView;
         nativeView.itemViewLoader = (viewType: any): View => this.loadView(viewType);
         this.nativeView.on(Pager.itemLoadingEvent, this.updateListItem, this);
+        this.nativeView.on(Pager.itemDisposingEvent, this.disposeListItem, this);
     }
 
     private loadView(viewType: string): View {
@@ -118,6 +119,13 @@ export default class PagerViewElement extends NativeViewElementNode<Pager> {
             }
         }
     }
+    private disposeListItem(args: ItemEventData) {
+        const _view = args.view;
+        if (_view.__SvelteComponent__) {
+            _view.__SvelteComponent__.$destroy();
+            _view.__SvelteComponent__ = null;
+        }
+    }
     private updateListItem(args: ItemEventData & { bindingContext }) {
         const _view = args.view;
         const props = { item: args.bindingContext, index: args.index };

src/ui-pager/vue/pager.ts

@@ -93,11 +93,11 @@ export default {
         },
         onItemDisposing(args) {
             // TODO: handle disposing template
-            // const oldVnode = args.view && args.view[ VUE_VIEW ];
-            // console.log("disposing", !!oldVnode, VUE_VIEW);
-            // if (oldVnode) {
-            // 	Vue.prototype.__patch__(oldVnode, null);
-            // }
+            const oldVnode = args.view && args.view[VUE_VIEW];
+            if (oldVnode) {
+                // properly dispose the oldVnode (this will unmount the tree)
+                this.__patch__(oldVnode, null);
+            }
         },
         onSelectedIndexChange({ value }) {
             this.$emit('selectedIndexChange', {