coll/basic CID 1516465: remove bad free

jsquyres · jsquyres · commit 98a37c968a37 · 2022-11-11T12:30:19.000-05:00
tmpbuf2 is never assigned a pointer value that can be freed.

Signed-off-by: Jeff Squyres &lt;jsquyres@cisco.com&gt;
diff --git a/ompi/mca/coll/basic/coll_basic_reduce_scatter_block.c b/ompi/mca/coll/basic/coll_basic_reduce_scatter_block.c
@@ -15,6 +15,7 @@
  * Copyright (c) 2014-2018 Research Organization for Information Science
  *                         and Technology (RIST). All rights reserved.
  * Copyright (c) 2022      IBM Corporation.  All rights reserved.
+ * Copyright (c) 2022      Cisco Systems, Inc.  All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -174,9 +175,5 @@ mca_coll_basic_reduce_scatter_block_inter(const void *sbuf, void *rbuf, int rcou
         free(tmpbuf);
     }
 
-    if (NULL != tmpbuf2) {
-        free(tmpbuf2);
-    }
-
     return err;
 }

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`* Copyright (c) 2014-2018 Research Organization for Information Science`
`16`	`16`	`* and Technology (RIST). All rights reserved.`
`17`	`17`	`* Copyright (c) 2022 IBM Corporation. All rights reserved.`
	`18`	`+ * Copyright (c) 2022 Cisco Systems, Inc. All rights reserved.`
`18`	`19`	`* $COPYRIGHT$`
`19`	`20`	`*`
`20`	`21`	`* Additional copyrights may follow`
`@@ -174,9 +175,5 @@ mca_coll_basic_reduce_scatter_block_inter(const void sbuf, void rbuf, int rcou`
`174`	`175`	`free(tmpbuf);`
`175`	`176`	`}`
`176`	`177`
`177`		`- if (NULL != tmpbuf2) {`
`178`		`- free(tmpbuf2);`
`179`		`- }`
`180`		`-`
`181`	`178`	`return err;`
`182`	`179`	`}`