Spapadop/plt 859 stabilize devenv startup script so generated devenvs boot#24
Merged
spapa013 merged 8 commits intonauticalab:develop/spapadopfrom Mar 6, 2026
Conversation
… UID/GID lookups and conditional rename/create logic for the dev account.
…tall to prevent breakage from stale UID/GID ownership
…tup failure on missing directory
…tion and remove conflicting filepath tag so valid absolute paths pass consistently
… shell quoting for user/group and path arguments
…h is used and venv python is missing
… setup to prevent stale-dotfile permission failures (e.g. .bashrc)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Mar 5, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the startup reliability remediation bundle for generated DevEnv pods so bootstrap consistently reaches
sshdand usable SSH access, including stale persistent-storage recovery paths.What Changed
User/group provisioning reliability
getent passwd/getent group.useradd -g ...).Homebrew persistent storage remediation
/home/linuxbrewand/home/linuxbrew/.linuxbrewexistVS Code startup hardening
.vscode-serverexists before ownership repair to avoidset -eabort on missing directory.Python path + config validation consistency
filepathvalidator onpythonBinPath.pythonBinPathmust be absolute.Python bootstrap reliability
/opt/venvbootstrap when defaultpythonBinPath(/opt/venv/bin) is used but interpreter is missing:python3-venv/opt/venvPersistent home stale-ownership remediation
/home/<user>before user environment setup..bashrc: Permission deniedwhen stale files persist across runs.Shell robustness
Why
Validation exposed multiple independent startup failure modes that could prevent pods from becoming usable before
sshdlaunch. This PR addresses the coordinated set required for reliable generated DevEnv bootstrap on Kubernetes, including stale persistent-storage scenarios.Validation Performed
go test ./internal/configsshd/opt/venv/bin/python3path case resolved via venv bootstrap.vscode-serverno longer causes startup failure.bashrcand restart path (no permission-denied setup failure)Notes
This issue tracks the full tactical startup remediation set needed for generated DevEnv bootstrap reliability and aligns with the completion criteria in the issue description.