Frequencies (#330)

* Fix QZSS LEX frequency, improve BDS definitions
* Fix a few warnings

---------

Signed-off-by: Guillaume W. Bres <[email protected]>

Author: gwbres

src/carrier.rs

@@ -4,7 +4,7 @@ use crate::{
     epoch::epoch_decompose as epoch_decomposition,
     error::FormattingError,
     hatanaka::{NumDiff, TextDiff},
-    observation::{HeaderFields, LliFlags, Record},
+    observation::{HeaderFields, Record},
     prelude::{Observable, SV},
     BufWriter,
 };

src/hatanaka/compressor.rs

@@ -70,7 +70,6 @@ impl TextDiff {
     pub fn compress(&mut self, data: &str) -> &str {
         let len = data.len();
         let mut buf_len = self.buffer.len();
-        let min_len = std::cmp::min(len, buf_len);
 
         if buf_len > len {
             // special case: shrink history
@@ -87,7 +86,7 @@ impl TextDiff {
 
             while let Some(buffered) = buffered.next() {
                 let byte = bytes.next().unwrap();
-                let mut compressed = compressed.next().unwrap();
+                let compressed = compressed.next().unwrap();
                 if byte == buffered {
                     *compressed = b' ';
                 } else {

src/hatanaka/textdiff.rs

@@ -1,7 +1,5 @@
 //! RINEX header formatting
 
-use gnss::constellation;
-
 use crate::{
     fmt_comment, fmt_rinex,
     header::Header,

src/header/formatting.rs

@@ -42,8 +42,8 @@ pub fn format<W: Write>(
         grid.longitude.spacing,
     );
 
-    let mut nth_map = 0;
-    let mut has_h = false;
+    let nth_map = 0;
+    let has_h = false;
     let mut has_rms = false;
 
     for t in record.keys().map(|k| k.epoch).unique().sorted() {

src/ionex/formatting.rs

@@ -1,8 +1,5 @@
 //! Meteo specific Header fields
-use std::{
-    io::{BufWriter, Write},
-    str::FromStr,
-};
+use std::io::{BufWriter, Write};
 
 use crate::prelude::FormattingError;
 
@@ -12,6 +9,9 @@ use serde::{Deserialize, Serialize};
 #[cfg(feature = "processing")]
 use qc_traits::{FilterItem, MaskFilter, MaskOperand};
 
+#[cfg(feature = "processing")]
+use std::str::FromStr;
+
 use crate::{meteo::Sensor, prelude::Observable};
 
 /// Meteo specific header fields

src/meteo/header.rs

@@ -1,13 +1,9 @@
 use crate::{
     epoch::parse_in_timescale as parse_epoch_in_timescale,
-    error::FormattingError,
     prelude::{Epoch, ParsingError, TimeScale},
 };
 
-use std::{
-    io::{BufWriter, Write},
-    str::FromStr,
-};
+use std::str::FromStr;
 
 /// BDGIM Model payload
 #[derive(Debug, Copy, Clone, Default, PartialEq, PartialOrd)]

src/navigation/ionosphere/bdgim.rs

@@ -316,7 +316,12 @@ impl Observable {
             if let Ok(carrier) = self.carrier(constellation) {
                 matches!(
                     carrier,
-                    Carrier::L1 | Carrier::E1 | Carrier::G1(_) | Carrier::S1 | Carrier::B2I
+                    Carrier::L1
+                        | Carrier::E1
+                        | Carrier::G1(_)
+                        | Carrier::S1
+                        | Carrier::B1c
+                        | Carrier::B1a
                 )
             } else {
                 false

src/observable.rs

@@ -179,11 +179,11 @@ impl Rinex {
 }
 
 #[cfg(test)]
+#[cfg(feature = "flate2")]
 mod test {
     use crate::prelude::Rinex;
 
     #[test]
-    #[cfg(feature = "flate2")]
     fn glacier_20240506_dominant_sample_rate() {
         let rnx = Rinex::from_gzip_file(format!(
             "{}/data/OBS/V3/240506_glacier_station.obs.gz",

src/sampling.rs

@@ -38,10 +38,12 @@ mod test {
         assert_eq!(antenna.calibration.method, CalibrationMethod::Chamber);
         assert_eq!(antenna.calibration.agency, "IGG, Univ. Bonn");
         assert_eq!(antenna.calibration.number, 1);
+
         assert_eq!(
             antenna.calibration.date,
             Epoch::from_str("2023-09-20T00:00:00 UTC").unwrap()
         );
+
         assert_eq!(
             antenna.zenith_grid,
             Linspace {
@@ -80,10 +82,11 @@ mod test {
 
         // B2B frequency
         assert!(
-            freq_data.get(&Carrier::B2B).is_some(),
+            freq_data.get(&Carrier::B2b).is_some(),
             "missing specs for B2B frequency"
         );
-        let b2b_specs = freq_data.get(&Carrier::B2B).unwrap();
+
+        let b2b_specs = freq_data.get(&Carrier::B2b).unwrap();
         assert_eq!(
             b2b_specs.apc_eccentricity,
             (0.32, -0.63, 160.39),