Add tests for preserve_keys flag and fallback

Author: navarr

src/IterableToArray.php

@@ -43,6 +43,25 @@ public static function convert(iterable $iterable, bool $preserve_keys = true):
         }
 
         // Fallback for supposedly impossible scenario
+        return self::fallbackConvert($iterable, $preserve_keys);
+    }
+
+    /**
+     * Fallback to convert an iterable into an array
+     *
+     * This should, theoretically, never be used.  However, for the sake of forward-compatibility, it exists and is
+     * tested.
+     *
+     * It is extracted into its own private method to allow for unit testing.
+     *
+     * @template T
+     * @param iterable<T> $iterable
+     * @param bool $preserve_keys
+     * @return array<T>
+     */
+    #[Pure]
+    private static function fallbackConvert(iterable $iterable, bool $preserve_keys): array
+    {
         $result = [];
         foreach ($iterable as $key => $value) {
             if ($preserve_keys) {

tests/IterableToArrayTest.php

@@ -10,7 +10,9 @@
 namespace Navarr\Utils;
 
 use ArrayIterator;
+use PHPStan\BetterReflection\Reflection\Adapter\ReflectionClass;
 use PHPUnit\Framework\TestCase;
+use ReflectionMethod;
 
 class IterableToArrayTest extends TestCase
 {
@@ -41,4 +43,42 @@ public function testConvertWithIteratorDoesNotPreserveKeys()
         $this->assertEquals(['b'], $result);
         $this->assertNotEquals(['a' => 'b'], $result);
     }
+
+    /**
+     * @dataProvider fallbackDataProvider
+     */
+    public function testFallback(iterable $iterator, bool $preserve_keys, array $expectedResult)
+    {
+        $reflectionMethod = new ReflectionMethod(IterableToArray::class, 'fallbackConvert');
+        $reflectionMethod->setAccessible(true);
+        $result = $reflectionMethod->invoke(null, $iterator, $preserve_keys);
+
+        $this->assertEquals($expectedResult, $result);
+    }
+
+    public function fallbackDataProvider(): array
+    {
+        return [
+            'Array w/ keys' => [
+                ['a' => 'b'],
+                true,
+                ['a' => 'b'],
+            ],
+            'Array w/out keys' => [
+                ['a', 'b'],
+                false,
+                ['a', 'b'],
+            ],
+            'Iterable w/ keys' => [
+                new ArrayIterator(['a' => 'b']),
+                true,
+                ['a' => 'b'],
+            ],
+            'Iterable w/out keys' => [
+                new ArrayIterator(['a', 'b']),
+                false,
+                ['a', 'b'],
+            ],
+        ];
+    }
 }