Skip to content

Commit 9a6764f

Browse files
committed
Fix comments for enabling -fmodles-driver and StandaloneDiag.
1 parent 8c71b82 commit 9a6764f

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

clang/lib/Driver/Driver.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1835,9 +1835,10 @@ Compilation *Driver::BuildCompilation(ArrayRef<const char *> ArgList) {
18351835
if (C->getArgs().hasFlag(options::OPT_fmodules_driver,
18361836
options::OPT_fno_modules_driver, false)) {
18371837
Diags.Report(diag::remark_performing_driver_managed_module_build);
1838-
// TODO: Once -fmodules-driver is no longer experimental, move
1839-
// TODO: The detection logic to implicitly enable -fmodules-driver is kept
1840-
// here only for diagnostics until the feature is no longer experimental.
1838+
// TODO: When -fmodules-driver is no longer experimental, allow implicit
1839+
// activation of the modules driver. For now, keep the detection of whether
1840+
// the modules driver should be enabled here for diagnostics only, and do
1841+
// not implicitly enable the feature.
18411842
auto EnableOrErr = modules::shouldUseModulesDriver(Inputs, getVFS(), Diags);
18421843
if (!EnableOrErr) {
18431844
llvm::handleAllErrors(

clang/lib/Driver/ModulesDriver.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,9 @@ StandaloneDiagnostic::StandaloneDiagnostic(const StoredDiagnostic &StoredDiag)
342342

343343
/// Translates \c StandaloneDiag into a StoredDiagnostic, associating it with
344344
/// the provided FileManager and SourceManager.
345+
///
346+
/// Use this to translate a \c StandaloneDiagnostic into a form that can be
347+
/// emitted by the diagnostics engine.
345348
static StoredDiagnostic
346349
translateStandaloneDiag(FileManager &FileMgr, SourceManager &SrcMgr,
347350
StandaloneDiagnostic &&StandaloneDiag) {

0 commit comments

Comments
 (0)