refactor: Change BigDecimal normalized() to 0-1 range and add stripTrailingZeros()

Author: kail-is

fixture-monkey-api/src/main/java/com/navercorp/fixturemonkey/api/arbitrary/BigDecimalCombinableArbitrary.java

@@ -69,6 +69,13 @@ public interface BigDecimalCombinableArbitrary extends CombinableArbitrary<BigDe
 	 */
 	BigDecimalCombinableArbitrary percentage();
 
+	/**
+	 * Generates a BigDecimalCombinableArbitrary which produces BigDecimals as score values (0-100).
+	 *
+	 * @return the BigDecimalCombinableArbitrary producing score BigDecimals
+	 */
+	BigDecimalCombinableArbitrary score();
+
 	/**
 	 * Generates a BigDecimalCombinableArbitrary which produces BigDecimals as score values within the specified range.
 	 *
@@ -95,13 +102,19 @@ public interface BigDecimalCombinableArbitrary extends CombinableArbitrary<BigDe
 	BigDecimalCombinableArbitrary withScale(int scale);
 
 	/**
-	 * Generates a BigDecimalCombinableArbitrary which produces normalized BigDecimals.
-	 * Normalized BigDecimals have trailing zeros removed and scale adjusted accordingly.
+	 * Generates a BigDecimalCombinableArbitrary which produces normalized BigDecimals (0.0 to 1.0).
 	 *
 	 * @return the BigDecimalCombinableArbitrary producing normalized BigDecimals
 	 */
 	BigDecimalCombinableArbitrary normalized();
 
+	/**
+	 * Generates a BigDecimalCombinableArbitrary which produces BigDecimals with trailing zeros removed.
+	 *
+	 * @return the BigDecimalCombinableArbitrary producing BigDecimals without trailing zeros
+	 */
+	BigDecimalCombinableArbitrary stripTrailingZeros();
+
 	@Override
 	default BigDecimalCombinableArbitrary filter(Predicate<BigDecimal> predicate) {
 		return this.filter(DEFAULT_MAX_TRIES, predicate);

fixture-monkey-api/src/main/java/com/navercorp/fixturemonkey/api/arbitrary/BigDecimalCombinableArbitraryDelegator.java

@@ -66,6 +66,11 @@ public BigDecimalCombinableArbitrary percentage() {
 		return CombinableArbitrary.bigDecimals().percentage();
 	}
 
+	@Override
+	public BigDecimalCombinableArbitrary score() {
+		return CombinableArbitrary.bigDecimals().score();
+	}
+
 	@Override
 	public BigDecimalCombinableArbitrary score(BigDecimal min, BigDecimal max) {
 		return CombinableArbitrary.bigDecimals().score(min, max);
@@ -86,6 +91,11 @@ public BigDecimalCombinableArbitrary normalized() {
 		return CombinableArbitrary.bigDecimals().normalized();
 	}
 
+	@Override
+	public BigDecimalCombinableArbitrary stripTrailingZeros() {
+		return CombinableArbitrary.bigDecimals().stripTrailingZeros();
+	}
+
 	@Override
 	public void clear() {
 		delegate.clear();

fixture-monkey-api/src/main/java/com/navercorp/fixturemonkey/api/jqwik/JqwikBigDecimalCombinableArbitrary.java

@@ -86,6 +86,13 @@ public BigDecimalCombinableArbitrary percentage() {
 		);
 	}
 
+	@Override
+	public BigDecimalCombinableArbitrary score() {
+		return new JqwikBigDecimalCombinableArbitrary(
+			Arbitraries.bigDecimals().between(BigDecimal.ZERO, BigDecimal.valueOf(100))
+		);
+	}
+
 	@Override
 	public BigDecimalCombinableArbitrary score(BigDecimal min, BigDecimal max) {
 		return withRange(min, max);
@@ -107,6 +114,13 @@ public BigDecimalCombinableArbitrary withScale(int scale) {
 
 	@Override
 	public BigDecimalCombinableArbitrary normalized() {
+		return new JqwikBigDecimalCombinableArbitrary(
+			Arbitraries.bigDecimals().between(BigDecimal.ZERO, BigDecimal.ONE)
+		);
+	}
+
+	@Override
+	public BigDecimalCombinableArbitrary stripTrailingZeros() {
 		return new JqwikBigDecimalCombinableArbitrary(
 			this.bigDecimalArbitrary.map(BigDecimal::stripTrailingZeros)
 		);

fixture-monkey-kotest/src/main/kotlin/com/navercorp/fixturemonkey/kotest/KotestBigDecimalCombinableArbitrary.kt

@@ -65,6 +65,11 @@ class KotestBigDecimalCombinableArbitrary(
             Arb.bigDecimal().filter { it >= BigDecimal.ZERO && it <= BigDecimal.valueOf(100) }
         )
 
+    override fun score(): BigDecimalCombinableArbitrary =
+        KotestBigDecimalCombinableArbitrary(
+            Arb.bigDecimal().filter { it >= BigDecimal.ZERO && it <= BigDecimal.valueOf(100) }
+        )
+
     override fun score(min: BigDecimal, max: BigDecimal): BigDecimalCombinableArbitrary =
         withRange(min, max)
 
@@ -79,6 +84,11 @@ class KotestBigDecimalCombinableArbitrary(
         )
 
     override fun normalized(): BigDecimalCombinableArbitrary =
+        KotestBigDecimalCombinableArbitrary(
+            Arb.bigDecimal().filter { it >= BigDecimal.ZERO && it <= BigDecimal.ONE }
+        )
+
+    override fun stripTrailingZeros(): BigDecimalCombinableArbitrary =
         KotestBigDecimalCombinableArbitrary(
             Arb.bigDecimal().map { it.stripTrailingZeros() }
         )