Skip to content

Commit b7f5b33

Browse files
authored
Polish java module test codes
Signed-off-by: Taeik Lim <[email protected]>
1 parent 56118f5 commit b7f5b33

File tree

40 files changed

+3520
-5115
lines changed

40 files changed

+3520
-5115
lines changed

spring-batch-plus/src/integrationTest/java/com/navercorp/spring/batch/plus/item/adapter/ItemStreamReaderProcessorWriterIntegrationTest.java

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818

1919
package com.navercorp.spring.batch.plus.item.adapter;
2020

21-
import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemProcessor;
22-
import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemStreamReader;
23-
import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemStreamWriter;
2421
import static org.assertj.core.api.Assertions.assertThat;
2522

2623
import java.util.UUID;
@@ -56,7 +53,8 @@
5653

5754
import reactor.core.publisher.Flux;
5855

59-
@SuppressWarnings("unchecked")
56+
// note: it's deprecated. Do not change it.
57+
@SuppressWarnings({"unchecked", "deprecation"})
6058
class ItemStreamReaderProcessorWriterIntegrationTest {
6159

6260
private static final int TEST_REPEAT_COUNT = 5;
@@ -112,9 +110,9 @@ void testReaderProcessorWriter() throws Exception {
112110
.start(
113111
new StepBuilder("testStep", jobRepository)
114112
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
115-
.reader(itemStreamReader(testTasklet))
116-
.processor(itemProcessor(testTasklet))
117-
.writer(itemStreamWriter(testTasklet))
113+
.reader(AdapterFactory.itemStreamReader(testTasklet))
114+
.processor(AdapterFactory.itemProcessor(testTasklet))
115+
.writer(AdapterFactory.itemStreamWriter(testTasklet))
118116
.build()
119117
)
120118
.build();
@@ -157,9 +155,9 @@ void testReaderProcessorWriterWithSameTaskletShouldKeepContext() throws Exceptio
157155
.start(
158156
new StepBuilder("testStep", jobRepository)
159157
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
160-
.reader(itemStreamReader(testTasklet))
161-
.processor(itemProcessor(testTasklet))
162-
.writer(itemStreamWriter(testTasklet))
158+
.reader(AdapterFactory.itemStreamReader(testTasklet))
159+
.processor(AdapterFactory.itemProcessor(testTasklet))
160+
.writer(AdapterFactory.itemStreamWriter(testTasklet))
163161
.build()
164162
)
165163
.build();
@@ -198,9 +196,9 @@ void testStepScopeReaderProcessorWriter() throws Exception {
198196
.start(
199197
new StepBuilder("testStep", jobRepository)
200198
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
201-
.reader(itemStreamReader(testTasklet))
202-
.processor(itemProcessor(testTasklet))
203-
.writer(itemStreamWriter(testTasklet))
199+
.reader(AdapterFactory.itemStreamReader(testTasklet))
200+
.processor(AdapterFactory.itemProcessor(testTasklet))
201+
.writer(AdapterFactory.itemStreamWriter(testTasklet))
204202
.build()
205203
)
206204
.build();
@@ -243,9 +241,9 @@ void testStepScopeReaderProcessorWriterWithSameTaskletShouldNotKeepCountContext(
243241
.start(
244242
new StepBuilder("testStep", jobRepository)
245243
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
246-
.reader(itemStreamReader(testTasklet))
247-
.processor(itemProcessor(testTasklet))
248-
.writer(itemStreamWriter(testTasklet))
244+
.reader(AdapterFactory.itemStreamReader(testTasklet))
245+
.processor(AdapterFactory.itemProcessor(testTasklet))
246+
.writer(AdapterFactory.itemStreamWriter(testTasklet))
249247
.build()
250248
)
251249
.build();

spring-batch-plus/src/integrationTest/java/com/navercorp/spring/batch/plus/item/adapter/ItemStreamReaderWriterIntegrationTest.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
package com.navercorp.spring.batch.plus.item.adapter;
2020

21-
import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemStreamReader;
22-
import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemStreamWriter;
2321
import static org.assertj.core.api.Assertions.assertThat;
2422

2523
import java.util.UUID;
@@ -55,7 +53,8 @@
5553

5654
import reactor.core.publisher.Flux;
5755

58-
@SuppressWarnings("unchecked")
56+
// note: it's deprecated. Do not change it.
57+
@SuppressWarnings({"unchecked", "deprecation"})
5958
class ItemStreamReaderWriterIntegrationTest {
6059

6160
private static final int TEST_REPEAT_COUNT = 5;
@@ -107,8 +106,8 @@ void testReaderWriter() throws Exception {
107106
.start(
108107
new StepBuilder("testStep", jobRepository)
109108
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
110-
.reader(itemStreamReader(testTasklet))
111-
.writer(itemStreamWriter(testTasklet))
109+
.reader(AdapterFactory.itemStreamReader(testTasklet))
110+
.writer(AdapterFactory.itemStreamWriter(testTasklet))
112111
.build()
113112
)
114113
.build();
@@ -151,8 +150,8 @@ void testReaderWriterWithSameTaskletShouldKeepCountContext() throws Exception {
151150
.start(
152151
new StepBuilder("testStep", jobRepository)
153152
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
154-
.reader(itemStreamReader(testTasklet))
155-
.writer(itemStreamWriter(testTasklet))
153+
.reader(AdapterFactory.itemStreamReader(testTasklet))
154+
.writer(AdapterFactory.itemStreamWriter(testTasklet))
156155
.build()
157156
)
158157
.build();
@@ -190,8 +189,8 @@ void testStepScopeReaderWriter() throws Exception {
190189
.start(
191190
new StepBuilder("testStep", jobRepository)
192191
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
193-
.reader(itemStreamReader(testTasklet))
194-
.writer(itemStreamWriter(testTasklet))
192+
.reader(AdapterFactory.itemStreamReader(testTasklet))
193+
.writer(AdapterFactory.itemStreamWriter(testTasklet))
195194
.build()
196195
)
197196
.build();
@@ -234,8 +233,8 @@ void testStepScopeReaderWriterWithSameTaskletShouldNotKeepCountContext() throws
234233
.start(
235234
new StepBuilder("testStep", jobRepository)
236235
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
237-
.reader(itemStreamReader(testTasklet))
238-
.writer(itemStreamWriter(testTasklet))
236+
.reader(AdapterFactory.itemStreamReader(testTasklet))
237+
.writer(AdapterFactory.itemStreamWriter(testTasklet))
239238
.build()
240239
)
241240
.build();

0 commit comments

Comments
 (0)